lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Updating code to use C++11


From: Greg Chicares
Subject: Re: [lmi] Updating code to use C++11
Date: Mon, 25 Jan 2016 14:44:10 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0

On 2016-01-25 12:51, Vadim Zeitlin wrote:
> On Mon, 25 Jan 2016 02:58:00 +0000 Greg Chicares <address@hidden> wrote:
[...]
> ---------------------------------- >8 --------------------------------------
> -    typedef std::vector<std::string>::const_iterator sci;
> -    for(sci i = all_headers.begin(); i != all_headers.end(); ++i)
> +    for(const auto & header : all_headers)
> ---------------------------------- >8 --------------------------------------

Can we write
  for(auto const& header : all_headers)
? Well, I could boot an msw VM where I have MinGW-w64 gcc-4.9.1 working
and see for myself, but right now I'd rather focus on cross compiling.
But that's the kind of question I'd like to explore up front, before
you write comprehensive patchsets. This is a good opportunity to choose
one uniform style and apply it everywhere.

> Anyhow, I'll send separate
> emails with the rationale (if necessary) and the examples of the proposed
> changes, starting from the simplest ones.

First, we need to test the compiler upgrade in the office (this week),
and resolve that awful libtool problem.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]