[lmi] Fwd: 'Οχι day is almost upon us [Was: Call for suggestions: new input fields]

[Greg Chicares]

[resending because original was missing from html archive]


-------- Forwarded Message --------
Subject: [lmi] 'Οχι day is almost upon us [Was: Call for suggestions: new input 
fields]
Date: Sun, 04 Oct 2015 14:40:12 +0000
From: Greg Chicares <address@hidden>
Reply-To: Let me illustrate... <address@hidden>
To: Let me illustrate... <address@hidden>

[I refer to 1940-10-28, not the 2015 referendum]

On 2005-10-15 04:08, Greg Chicares wrote:
> [...] the time to speak up is by Oxi Day.
>  - [...] I'll expunge "idiosyncrasy_spreadsheet"
>    once we make the right supplemental-report columns available.
>    Idiosyncrasies--just say "oxi".

This is marked "Closed":
  http://savannah.nongnu.org/support/?105597
I suppose it was addressed by adding
  Illustration | Copy full illustration data
though I'm no longer really sure.

If there's a good reason to keep 'idiosyncrasy_spreadsheet', speak
up now. Otherwise, we have additional reasons for removing it now:
 - Vadim's working on the general problem of lmi trying to open
   a file that's locked in a spreadsheet program, and that problem
   arises here (as SR 105597 points out).
 - This is an illustration, and it's not specifically blocked for
   non-illustrated forms. I'm not sure it's reachable through any
   code path that isn't already blocked, but it's unconscionable
   not to add a specific block on this potential back door to
   violation of the NAIC illustration regulation.
If there's no reason to keep 'idiosyncrasy_spreadsheet', then
removing it is the best way to get rid of those problems.

Assuming we'll just say "oxi"...Vadim, is the patch below correct?
(I'm confident I know how to handle 'ledger_xml_io.cpp'.)

Index: wx_test_validate_output.cpp
===================================================================
--- wx_test_validate_output.cpp (revision 6315)
+++ wx_test_validate_output.cpp (working copy)
@@ -337,21 +337,8 @@
 {
     wxUIActionSimulator ui;

-    ui.Char('e', wxMOD_CONTROL | wxMOD_SHIFT); // "Census|Edit case defaults"
-    wxTEST_DIALOG
-        (wxYield()
-        ,enter_comments_in_case_defaults_dialog("idiosyncrasy_spreadsheet")
-        ,wxExpectModal<wxMessageDialog>(wxYES).
-            Describe("message box asking whether to apply changes to all 
cells")
-        );
-
     ui.Char('s', wxMOD_CONTROL); // "File|Save"

-    fs::path values_file(configurable_settings::instance().print_directory());
-    values_file /= "values" + tsv_ext();
-
-    output_file_existence_checker output_values(values_file);
-
     // We don't really care about these files existence, but we don't want them
     // to be left over after the end of this test, so use the output existence
     // checker helper to ensure that they are cleaned up.
@@ -363,11 +350,6 @@

     ui.Char('i', wxMOD_CONTROL | wxMOD_SHIFT); // "Census|Print case to PDF"
     wxYield();
-
-    LMI_ASSERT_WITH_MSG
-        (output_values.exists()
-        ,"file \"" << values_file << "\" after print case to PDF"
-        );
 }

 void validate_run_cell_and_copy_output
@@ -469,14 +451,6 @@
 //    ABC.cns.roster.tsv
 /// ...and delete all three now.
 ///
-/// Census | Edit case defaults
-///   Comments: replace contents with "idiosyncrasy_spreadsheet"
-///   OK
-///   Yes (apply to all)
-/// Census | Print case to PDF
-/// Verify that this file was created:
-///   values.tsv
-///
 /// select the "John Brown" cell
 /// Census | Run cell
 /// Illustration | Copy full illustration data [Ctrl-D]


_______________________________________________
lmi mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/lmi