Re: [lmi] [PATCH] Error reporting

[Vadim Zeitlin]

On Thu, 26 Mar 2015 23:28:48 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2015-03-09 18:52, Vadim Zeitlin wrote:
GC> > On Fri, 05 Dec 2014 20:47:32 +0000 Greg Chicares <address@hidden> wrote:
GC> > 
GC> > GC> We accidentally made a change that prevented wx errors from being
GC> > GC> displayed. I'd like to add an automated test that would flag that
GC> > GC> problem in case we accidentally make a similar mistake in the future.
GC> > 
GC> >  I definitely agree that it's important to have a test for this, but
GC> > this did require some more extensive changes, let me explain why:
GC> [...big snip...]
GC> 
GC> Committed
GC>   20150326T2250Z, revision 6146;
GC>   20150326T2257Z, revision 6147;
GC>   20150326T2308Z, revision 6148; and
GC>   20150326T2327Z, revision 6149.
GC> 
GC> I forced the fourth patch manually (it seemed to conflict with an
GC> earlier one). It's so simple that I "couldn't possibly get it wrong",
GC> which means mistakes are likely here: please check my work carefully.

 Thanks for these commits but unfortunately something did seem to go wrong
here, it looks like the changes to main_wx_test.cpp were not part of r6146
(and this explains why r6149, which relied on having these changes, didn't
apply cleanly). I.e. if you look at the original patch:

        http://lists.nongnu.org/archive/html/lmi/2015-03/txt6pw1v_rlSN.txt

you can see that it contains changes to main_wx_test.cpp. But r6146 does
not change it at all:

        % g show --stat `g svn find-rev r6146`
        commit 99c25b64e3233d4373b18234c5e5f71e5f1e4ac5
        Author: Greg Chicares <address@hidden>
        Date:   Thu Mar 26 22:50:31 2015 +0000

            Use wxPrintf() instead of wxLogMessage() for GUI test

            git-svn-id: svn://svn.sv.gnu.org/lmi/lmi/address@hidden 
8995fb05-a277-41b4-a4d2-e84fd280a9a6

         ChangeLog                    |  9 +++++++++
         wx_test_about_version.cpp    |  4 ++--
         wx_test_benchmark_census.cpp |  6 +++---
         wx_test_default_input.cpp    | 12 ++++++------
         wx_test_expiry_dates.cpp     |  6 +++---
         5 files changed, 23 insertions(+), 14 deletions(-)

GC> [Always a good idea anyway]

 Yes, I keep the branches corresponding to my already submitted work and
delete them after verifying that they contain at most only trivial
differences with the trunk.
 

 To help you applying the missing parts, I reattach just the missing parts
after redoing the comparison of my branch with the current svn trunk, these
patches should apply cleanly to your latest versions. Could you please (re)
apply them?

 Thanks in advance!
VZ

0001-Use-wxPrintf-instead-of-wxLogMessage-for-the-test-su.patch
Description: Text document

0002-Flush-wxLog-after-every-test-execution-in-the-test-s.patch
Description: Text document