Re: [lmi] [PATCH] Trivial patch to avoid building unnecessary wxWidgets parts

[Vadim Zeitlin]

On Fri, 06 Mar 2015 18:14:18 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2015-03-04 00:45, Vadim Zeitlin wrote:
GC> > 
GC> >  I've recently mentioned in passing that install_wx.make could avoid
GC> > building some components of wxWidgets which were not used by lmi. As I had
GC> > to rebuild wx with gcc 3.4 once more myself today, I decided to change it
GC> > myself just to speed up the build, so here is the resulting trivial patch:
GC> 
GC> Committed 20150306T1754Z, revision 6121.
GC> 
GC> I used to run the wx sample programs often, but haven't run any of
GC> them for years, so I agree that  '--without-subdirs' is appropriate.

 Just FYI, you can still create the makefile for a sample you'd like to use
later by running

        $ CONFIG_FILES=samples/minimal/Makefile CONFIG_GHEADERS= ./config.status

or, equivalently, using the helper $WXWIN/regen script:

        $ $WXWIN/regen samples/minimal/Makefile


GC> > might enjoy faster build times (and smaller DLLs) too. Additionally, it is
GC> > somewhat strange to disable wxStyledTextCtrl (the existing 
"--disable-stc")
GC> > but not the other similar components, so this patch makes things more
GC> > consistent as well.
GC> 
GC> I don't seem to have recorded how long it took previously, but...

 Me neither exactly because it was too long to redo it again just to
benchmark it. It takes less than 10 minutes now (inside my 2 CPU VM, I
should probably give it 4 of them...) which is definitely a gain.

 Thanks for applying this,
VZ