Re: [lmi] Latest wx version recommendation

[Vadim Zeitlin]

On Sat, 28 Feb 2015 19:05:08 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2015-02-15 23:03, Vadim Zeitlin wrote:
GC> > 
GC> >  If you hadn't upgraded your version of wxWidgets yet, please consider
GC> > upgrading it to a later 64797a78ea419b24cf82fe43faf9760c51de95f0 commit
GC> > instead as it fixes a cosmetic, but noticeable, problem in wxDataViewCtrl
GC> > appearance which affected lmi census view if it was scrolled horizontally
GC> > (see http://trac.wxwidgets.org/ticket/16815 for more details about this
GC> > bug).
GC> 
GC> It seemed sensible to use 2f239930eb3bc8a928a771d4659e46900907b11f,
GC> which is the latest as of a few hours ago. Building it, I see:
GC> 
GC> ../src/common/event.cpp:1611: warning: 'loop' might be used uninitialized 
in this function
GC> ../src/common/docview.cpp:1526: warning: 'docNew' might be used 
uninitialized in this function
GC> ../src/richtext/richtextbuffer.cpp:712: warning: passing `double' for 
converting 1 of `void wxColourBase::Set(unsigned char, unsigned char, unsigned 
char, unsigned char)'
GC> ../src/richtext/richtextbuffer.cpp:712: warning: passing `double' for 
converting 2 of `void wxColourBase::Set(unsigned char, unsigned char, unsigned 
char, unsigned char)'
GC> ../src/richtext/richtextbuffer.cpp:712: warning: passing `double' for 
converting 3 of `void wxColourBase::Set(unsigned char, unsigned char, unsigned 
char, unsigned char)'
GC> 
GC> We've seen (and dismissed) the first two before, but the warnings
GC> about wxColourBase::Set()'s arguments are new.

 Yes, sorry, I've missed them in the middle of all these "'__cur' might be
used uninitialized in this function" warnings (in stl_uninitialized.h, no
less). Have you been able to get rid of those somehow by chance or are you
just much more diligent than I am at reading the compiler output?

GC> For ease of reference:
GC>     708         {
GC>     709             // Let's pretend our background is always white. 
Calculate a colour value
GC>     710             // from this and the opacity.
GC>     711             double p = 
attr.GetTextBoxAttr().GetShadow().GetOpacity().GetValue() / 100.0;
GC>     712             shadowColour.Set((1.0 - p)*255 + p*shadowColour.Red(), 
(1.0 - p)*255 + p*shadowColour.Green(), (1.0 - p)*255 + p*shadowColour.Blue()   
 712 );
GC>     713         }

 The warning is harmless, but I've just fixed it in the commit
3bec79d71cc7be818c89f4591d68b4a53d00da08 in wx git (BTW, wx doesn't use svn
any longer, finally, so there are no more associated revision numbers).

 I'd also like to mention that you might consider a few more --disable-xxx
lines to config_options in install_wx.make. I.e. there is absolutely no
reason to build wxRichtext library at all as long as lmi doesn't use it, so
--disable-richtext could be used. Similarly, lmi doesn't use a couple of
other wxWidgets components, so you could also add --disable-{aui,propgrid,
ribbon,stc,mediactrl,webview}. Even further reductions in the compilation
time and the size of the resulting libraries are possible by excluding more
individual controls, but those ones are the lowest hanging fruits and,
unlike some other switches, should always work as they disable building
independent components, usually compiled into their own libraries, and so
there are no complicated dependencies to maintain.


 Thanks for noticing this warning!
VZ