[lmi] Special build types, e.g. gcov [Was: wx_test regression]

[Greg Chicares]

On 2014-10-29 14:42Z, Vadim Zeitlin wrote:
> On Wed, 29 Oct 2014 00:08:49 +0000 Greg Chicares <address@hidden> wrote:
> 
> GC> Well, the really encouraging thing is that the automated GUI test
> GC> has already paid its first dividend, by finding a defect quickly
> GC> and cheaply. When 'wx_test' is finished and integrated into our
> GC> normal pre-commit procedures, it'll prevent defects like this
> GC> from being committed in the first place.
> 
>  Only tangentially related, but one thing I wanted to do was to use gcov
> with the test to see how much of the existing code does it cover (my
> suspicion is that the answer is "not much") and possibly try to extend them
> to cover more of it.

I note with surprise that I don't seem ever to have used gcov, even
though it's available with gcc-3.4.5 .

The lmi makefiles provide various special-purpose build types:
  grep build_type *make*
including one for gprof, so gcov should be easy to add. My first
thought would be to add it in parallel with (and distinct from)
gprof; is that the usual practice, or do most people use a single
build for both gprof and gcov, combining all their flags together?

BTW, I hadn't exercised lmi's 'so_test' build type since adding
the GUI tests, so this seemed like a good time to try it:

  make --jobs=16 all build_type=so_test USE_SO_ATTRIBUTES=1  >../log 2>&1
/MinGW_/bin/g++  -o wx_test.exe main_wx_test.o wx_test_about_version.o 
wx_test_benchmark_census.o wx_test_calculation_summary.o 
wx_test_config_settings.o wx_test_create_open.o wx_test_default_input.o 
wx_test_default_update.o wx_test_expiry_dates.o wx_test_extract.o 
wx_test_input_sequences.o wx_test_input_validation.o wx_test_paste_census.o 
wx_test_pdf_create.o wx_test_validate_output.o lmi_msw_res.o skeleton.dll 
liblmi.dll -L . -L /opt/lmi/local/lib -L /opt/lmi/local/bin  -L 
/opt/lmi/local/lib
-lwx_mswu-3.1-i686-pc-mingw32 -mwindows    -lexslt -lxslt -lxml2        
-Wl,-Map,wx_test.exe.map -Wl,--disable-auto-import
wx_test_default_input.o:C:/opt/lmi/MinGW-20090203/bin/../lib/gcc/mingw32/3.4.5/../../../../include/c++/3.4.5/ext/new_allocator.h:62:
 undefined reference to `tn_range<calendar_date, date_trammel<calendar_date> 
>::value() const'
wx_test_default_input.o:C:/opt/lmi/MinGW-20090203/bin/../lib/gcc/mingw32/3.4.5/../../../../include/c++/3.4.5/ext/new_allocator.h:62:
 undefined reference to `datum_string::value() const'

We could, of course, decide that wx_test needn't be built this way,
but this is such a small problem that it seems better to fix it.
I think the easiest way is to use this:
  yare_input::yare_input(Input const& z)
which turns an Input instance into something whose members are
directly useful--e.g.:
    calendar_date                     EffectiveDate                   ;
    std::vector<double>               GeneralAccountRate              ;
Would you mind doing that? Oh, and this is really minute, but at the
same time would you change 'd' to 'r' in "general_account_date", to
correspond more closely to "GeneralAccountRate"?