Re: [lmi] [PATCH] Add undisplayable_exception

[Greg Chicares]

On 2014-10-11 12:02Z, Vadim Zeitlin wrote:
> On Sat, 11 Oct 2014 00:12:05 +0000 Greg Chicares <address@hidden> wrote:
[...]
> GC> It's hard to explain how utterly averse to abrupt termination our users 
> are,

To shed at least a little light on it: some office workers leave their
word processor open for a month, and rarely save documents. When they
lose weeks of work due to an abrupt termination, they may concede that
they might have saved more often, but still they feel ill served by
the software, hardware, network, electric company, etc. And we're not
going to implement "autosave" in lmi.

[snip patch that trapped 'wx_test_exception' explicitly in 'main_wx.cpp']

>  However I wonder if a more general fix might be even better: while it would
> work exactly in the same way as above patch right now, it would also remain
> safe even if more exceptions escape report_exception() in the future for
> any reason:

Thanks, that's better. Committed 20141012T1509Z, revision 5983.

>  I also like that this avoids mentioning wx_test_exception, which really
> has nothing to do in the production code, completely.

As you'll see, I removed that even more completely; in its stead is a
new base class, with a unit test to prove it all works as intended.