Re: [lmi] Forcing linking of the library modules (again)

[Greg Chicares]

[...still snipping the really important stuff, which I'll reply to later...]

On 2014-10-04 14:52Z, Vadim Zeitlin wrote:
> On Sat, 04 Oct 2014 13:20:57 +0000 Greg Chicares <address@hidden> wrote:
> GC> instead, I've cloned this code:
> GC>   
> http://svn.wxwidgets.org/viewvc/wx/wxWidgets/trunk/include/wx/link.h?view=co
> GC> to provide lmi-specific macros in new header 'force_linking.hpp'.

I'm puzzled. I think I preserved the original's substance faithfully, but...

>  But I'd like to notice that there is a small problem with the new
> LMI_FORCE_LINKING_{IN,EX}_SITU() macros: they are inconsistent in their
> handling of the subsequent semicolon as the former requires it, while the
> latter does not. I would prefer if the latter one required the semicolon as
> well, i.e. remove the trailing semicolon from the line 61 of
> force_linking.hpp

Isn't that the same as the trailing semicolon on line 28 here?

  
http://svn.wxwidgets.org/viewvc/wx/wxWidgets/trunk/include/wx/link.h?view=annotate
28                      } _wx_link_dummy_var_##module_name;

Or are you advocating a change to <wx/link.h> as well, for the following reason?

> , as not terminating the macro definition with a semicolon
> is the common rule