Re: [lmi] Allow opening cell editor with double-click

[Greg Chicares]

On 2011-12-30 16:42Z, Vaclav Slavik wrote:
> 
> I keep expecting double-clicking an entry in census view to open the editor,

Me, too.

> but it doesn't. I think this expectation comes from other Windows UIs,
> double-clicking ("activating") an item typically opens it.

Yes...and for double-clicking to do nothing at all just seems wrong.

> Wouldn't it be better if LMI followed this convention? It's a simple change,
> see the patch below.

With that patch, it's pretty easy to provoke a segfault, though it's
not as simple to describe how to do it. The key is apparently to hit F2
almost immediately after closing the Ctrl+E dialog. Sorry I can't make
it any clearer; it's easy to do if I just bang on the keys, but hard if
I go about it slowly and deliberately, so maybe it's a timing issue.
Here's sample crash report from a JIT debugger:

lmi_wx_shared.exe caused an Access Violation at location 6c5872f2 in module 
wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll Reading from 
location 00000000.

Registers:
eax=00000000 ebx=0000000d ecx=00000000 edx=0022f48c esi=6cdceb20 edi=03b6c3c0
eip=6c5872f2 esp=0022f3bc ebp=0022f3e4 iopl=0         nv up ei pl nz na po nc
cs=001b  ss=0023  ds=0023  es=0023  fs=003b  gs=0000             efl=00000206

Call stack:
AddrPC     AddrReturn AddrFrame  AddrStack  Params
6C5872F2   6C59C87E   0022F3E4   0022F3BC   03BB0F18   0022F48C   00000002   
6C5857F0
6C5872F2  
wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:6C5872F2C:\opt\lmi\local\lib\wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:
 No symbol found
  _ZN14wxDataViewCtrl21OnColumnsCountChangedEv
6C59C87E   6BD8430E   0022F5D4   0022F3BC   03BB0F18   0022F9BC   6C59C090   
00000000
6C59C87E  
wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:6C59C87EC:\opt\lmi\local\lib\wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:
 No symbol found
  _ZN14wxDataViewCtrl16DoSetCurrentItemERK14wxDataViewItem
6BD8430E   6BFB7C4E   0022F604   0022F3BC   0398C248   03BB0F18   03973CF0   
0022F9BC
6BD8430E  
wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:6BD8430EC:\opt\lmi\local\lib\wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:
 No symbol found
  
_ZNK16wxAppConsoleBase16CallEventHandlerEP12wxEvtHandlerR14wxEventFunctorR7wxEvent
6BFB7C4E   6BFBD713   0022F634   0022F3BC   6CF58B0C   03BB0F18   0022F9BC   
00000001
6BFB7C4E  
wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:6BFB7C4EC:\opt\lmi\local\lib\wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:
 No symbol found
  
_ZN12wxEvtHandler23ProcessEventIfMatchesIdERK21wxEventTableEntryBasePS_R7wxEvent
6BFBD713   6BFBD77E   0022F664   0022F3BC   6CF58B34   0022F9BC   03BB0F18   
6C4804CB
6BFBD713  
wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:6BFBD713C:\opt\lmi\local\lib\wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:
 No symbol found
  _ZN16wxEventHashTable11HandleEventER7wxEventP12wxEvtHandler
6BFBD77E   6BFBD7FC   0022F684   0022F3BC   03BB0F18   0022F9BC   00000000   
00000000
6BFBD77E  
wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:6BFBD77EC:\opt\lmi\local\lib\wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:
 No symbol found
  _ZN12wxEvtHandler11TryHereOnlyER7wxEvent
6BFBD7FC   6BFBD895   0022F6A4   0022F3BC   03BB0F18   0022F9BC   03BB0F18   
0022F908
6BFBD7FC  
wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:6BFBD7FCC:\opt\lmi\local\lib\wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:
 No symbol found
  _ZN12wxEvtHandler19ProcessEventLocallyER7wxEvent
6BFBD895   6BFB814C   0022F6D4   0022F3BC   03BB0F18   0022F9BC   0022F704   
6C16D9C1
6BFBD895  
wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:6BFBD895C:\opt\lmi\local\lib\wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:
 No symbol found
  _ZN12wxEvtHandler12ProcessEventER7wxEvent
6BFB814C   6C4804CB   0022F744   0022F3BC   03BB0F18   0022F9BC   0022FA44   
6C19806B
6BFB814C  
wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:6BFB814CC:\opt\lmi\local\lib\wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:
 No symbol found
  _ZN12wxEvtHandler18SafelyProcessEventER7wxEvent
6C4804CB   6C19806B   0022F754   0022F3BC   03BB0F18   0022F9BC   00000000   
03BB0F18
6C4804CB  
wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:6C4804CBC:\opt\lmi\local\lib\wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:
 No symbol found
  _ZNK12wxWindowBase17HandleWindowEventER7wxEvent
6C19806B   6C16E6B9   0022FA44   0022F3BC   03BB0F18   0022FA64   00000100   
00000071
6C19806B  
wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:6C19806BC:\opt\lmi\local\lib\wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:
 No symbol found
  _ZN8wxWindow16MSWHandleMessageEPljjl
6C16E6B9   6C175F50   0022FA74   0022F3BC   03BB0F18   00000100   00000071   
003C0001
6C16E6B9  
wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:6C16E6B9C:\opt\lmi\local\lib\wxmsw293u_gcc_gcc-345-6b6003713289ea4d3cd9b49c5db5b721.dll:
 No symbol found
  _ZN8wxWindow13MSWWindowProcEjjl
6C175F50   7E418734   0022FAA4   0022F3BC   063D0B34   00000100   00000071   
003C0001
...