Re: [lmi] 'Illustration' menu commands collide with accelerators

[Greg Chicares]

On 2008-12-31 23:06Z, Vaclav Slavik wrote:
[...]
>> >   Copy calculation summarCtrl-C [half of the 'r' is cut off]
> 
> It is caused by LMI's use of non-standard (!= 16x16) icons for menu
> items, together with a MSW quirk (if I remember it correctly). See the
> previous discussion of the bug here:
> http://lists.nongnu.org/archive/html/lmi/2008-03/msg00017.html

With the first patch below [1], which should make menus work as
though we already had a 16x16 iconset, what I see is not this:
>> >   Copy calculation summarCtrl-C [half of the 'r' is cut off]
but rather this, as nearly as flat text can represent it:
       Copy calculation summaryCtrl-C
Thus, 16x16 icons should indeed prevent the reported truncation.

Even so, "summary" and "Ctrl" are quite close together: there seems
to be only one pixel between them. The second patch below [2] puts
approximately one en-space between them, which looks much nicer.
But the technique of patch [2], writing an explicit extraneous
space, seems lame and too easy to forget.

I think we want the combined *effects* of both patches. But clearly
instead of patch [1], we'll just add 16x16 icons; I see no need for
wx to adjust for that. As for patch [2], though...well, we could
apply it once we have 16x16 icons, but wouldn't it be better to
accomplish its effect in wx, by making the '\t' here:
    <label>_Copy calculation summary\tCtrl-C</label>
produce a minimum spacing of e.g. five pixels or one en, instead of
one pixel as at present? Here, I hope I'm not again overlooking
something you already explained in the past.

---------

[1] "the first patch below"

Index: icon_monger.cpp
===================================================================
RCS file: /sources/lmi/lmi/icon_monger.cpp,v
retrieving revision 1.9
diff -U 3 -r1.9 icon_monger.cpp
--- icon_monger.cpp     27 Dec 2008 02:56:42 -0000      1.9
+++ icon_monger.cpp     1 Jan 2009 01:57:42 -0000
@@ -75,7 +75,7 @@
     return z;
 #else  // defined LMI_MSW
     // For the nonce, inhibit rescaling: it's not attractive enough.
-    return wxSize(24, 24);
+//    return wxSize(24, 24);
     if     (wxART_MENU    == client) {return wxSize(16, 16);}
     else if(wxART_TOOLBAR == client) {return wxSize(24, 24);}
     else                             {return z;}

[2] "The second patch below":

Index: menus.xrc
===================================================================
RCS file: /sources/lmi/lmi/menus.xrc,v
retrieving revision 1.48
diff -U 3 -r1.48 menus.xrc
--- menus.xrc   27 Dec 2008 02:56:49 -0000      1.48
+++ menus.xrc   1 Jan 2009 02:12:17 -0000
@@ -394,7 +394,7 @@
         </object>
         <object class="separator"/>
         <object class="wxMenuItem" name="copy_summary">
-            <label>_Copy calculation summary\tCtrl-C</label>
+            <label>_Copy calculation summary \tCtrl-C</label>
             <help>Copy calculation summary to the clipboard</help>
         </object>
         <object class="wxMenuItem" name="wxID_COPY">