[lmi] Reproducible html help crash

[Greg Chicares]

To reproduce: First, copy all '*.h*' files from here:
  http://web.cvs.savannah.nongnu.org/viewvc/lmi/lmi/
to your lmi data/ directory (where you install '*.xrc'); then:
  run lmi
  press F1 [html help appears]
  focus lmi's main window
  close lmi [File|Close or [X] button, doesn't matter]

Symptoms: If I run lmi under gdb, I get a reproducible segfault
(see backtrace below [1]). If I run with the "drmingw" JIT
debugger enabled, I get
    lmi_wx_shared.exe caused an Access Violation at location
    77de6439 in module ADVAPI32.DLL
    Reading from location 0671b1fc.
But in either of those cases, both lmi and the html help window
close, and stay closed: it's a normal crash.

However, with no debugger at all, something preternatural occurs.
First, lmi's main window and its html help window both close:
they vanish from the screen, and their "icons" vanish from the
msw "taskbar"; that's what I would expect to happen. But then lmi
is somehow resurrected, with a different PID and a new "taskbar
icon". That's all completely reproducible here with msw-xp. After
that happens, irreproducible weirdness may follow: e.g., I start
a new instance of lmi, and F1 creates a "taskbar icon" for html
help, but the only way I can get the html window to display at
all is to right-click its "icon" and maximize it manually--and
then the "navigation panel" is only about as wide as the two
"bookmark" pushbuttons.

I'm using wx-2.8.7: the wx tarball, patched with 'wx-2.8.7.patch'
in lmi's cvs. I'm using MinGW gcc-3.4.4, not any Cygwin compiler,
but I'm starting lmi from a Cygwin zsh prompt--and that seems to
be a necessary condition for the "resurrection" behavior, which
I'm unable to reproduce with CMD.EXE or a msw-native zsh. But I
witness "resurrection" with Cygwin bash, too. Weird.

---------

[1] gdb backtrace: this line
    /lmi/src/lmi/main_wx.cpp:571
is:
    delete help_controller_;
It looks like that triggers a ~wxHtmlHelpController() problem.

Program received signal SIGSEGV, Segmentation fault.
0x100dec41 in wxRegKey::SetValue ()
   from /opt/lmi/local/lib/cygwxmsw28_gcc_344-0.dll
(gdb) bt
#0  0x100dec41 in wxRegKey::SetValue ()
   from /opt/lmi/local/lib/cygwxmsw28_gcc_344-0.dll
#1  0x100d92be in wxRegConfig::DoWriteString ()
   from /opt/lmi/local/lib/cygwxmsw28_gcc_344-0.dll
#2  0x103b4215 in wxHtmlHelpWindow::WriteCustomization ()
   from /opt/lmi/local/lib/cygwxmsw28_gcc_344-0.dll
#3  0x103a0224 in wxHtmlHelpController::~wxHtmlHelpController ()
   from /opt/lmi/local/lib/cygwxmsw28_gcc_344-0.dll
#4  0x00427b28 in Skeleton::OnExit (this=0x33e8f24)
    at /lmi/src/lmi/main_wx.cpp:571
#5  0x10062ca0 in wxEntryReal ()
   from /opt/lmi/local/lib/cygwxmsw28_gcc_344-0.dll
#6  0x100fd64d in wxEntry () from /opt/lmi/local/lib/cygwxmsw28_gcc_344-0.dll
#7  0x0042896c in WinMain (hInstance=0x0, hPrevInstance=0x0, lpCmdLine=0x0,
    nCmdShow=0) at /lmi/src/lmi/main_wx.cpp:232
#8  0x0047dd98 in main (argc=3, argv=0x32c5630, __p__environ=0x3e2ab8)
    at ../../runtime/main.c:73