[lmi] Contextual-help anomaly

[Greg Chicares]

Using HEAD as of a few minutes ago, with wx-2.8.7, on msw:
  alt-F N I
  Enter [or Esc]
  ctrl-F
  F1
results in popup help "Blend mortality by gender", which isn't
correct for focused checkbox "Use built-in calculation summary".
Three other controls on this dialog are mapped to incorrect
help strings:
  "Column 0" --> "Set effective date to current date"
  "Column 1" --> "Case effective date"
  "Column 2" --> "Amortize all premium load components"...
The other controls on this dialog do not show any help.

I would expect no control on this dialog to be associated with
any contextual help whatsoever, because there are no <help>
elements in its XRC file.

I believe the test case above is irreducible. The anomalous help
strings are all contained in 'skin.xrc', which is the only file
that contains any <help> elements at all right now. The specific
elements in tab order for the 'Ctrl-F' dialog are [reformatted]:

  <object class="wxCheckBox" name="BlendGender">
      <help>Blend mortality by gender</help>
  <object class="wxCheckBox" name="EffectiveDateToday">
      <help>Set effective date to current date</help>
  <object class="wxDatePickerCtrl" name="EffectiveDate">
      <help>Case effective date</help>
  <object class="wxCheckBox" name="AmortizePremiumLoad">
      <help>Amortize all premium load components; charge an extra interest 
spread instead</help>

which is exactly the opposite of the order in which this command
finds them:

grep --after-context=1 'wxDatePickerCtrl\|wxCheckBox' skin.xrc | sed 12q

IOW, they're the <help> elements for the first four controls of
the given types in 'skin.xrc', but in reverse order. I would
speculate that there's interference in the contextual mappings
for control IDs that XRC automatically assigns to different
dialogs, at least when one dialog has no <help> elements.

Patching 'preferences_view.xrc' this way:

--- /lmi/src/lmi/preferences_view.xrc   2008-02-28 03:39:26.000000000 +0000
+++ preferences_view.xrc        2008-02-28 18:28:18.000000000 +0000
@@ -36,4 +36,5 @@
             <object class="wxCheckBox" name="UseBuiltinCalculationSummary">
                 <label>Use built-in calculation summary</label>
+                <help>This overrides the anomaly</help>
             </object>
         </object>

prevents the anomaly wrt that control only.