lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi] Requesting Evgeniy's review


From: Greg Chicares
Subject: [lmi] Requesting Evgeniy's review
Date: Wed, 01 Nov 2006 21:12:46 +0000
User-agent: Thunderbird 1.5.0.4 (Windows/20060516)

I'm trying to refactor all xml-library code, ideally so that
all calls to libxml++ occur in 'xml_lmi.?pp'. This may or
may not give us the option of substituting different xml
libraries, which may or may not be a good goal; but it is
educationally valuable to me, and I feel that the effort is
yielding clearer code. And safer code, too, because it's
easier to make sure all exceptions are trapped and all error
codes are checked. And above all it makes the transition
from xmlwrapp to libxml++ easier for me. Anyway, that's not
what I wanted to ask you about....

The last remaining use of this type:
    typedef std::list<xmlpp::Node*> NodeContainer;
(outside of 'xml_lmi.?pp') is in 'ledger_xml_io.cpp'. I made
tentative modifications there, in '#if 0' blocks so that I
wouldn't break anything. Could I ask you to review it over
the next day or two and let me know whether I've done it
correctly? It's different from other uses of 'NodeContainer'
because you are calling
    xmlpp::Node::get_children(argument)
with an actual argument, whereas elsewhere the argument is
just the default empty string. I've added such an argument
to this function
    xml_lmi::ElementContainer xml_lmi::child_elements
        (xml_lmi::Element const& parent
        ,std::string const& name
        )
but haven't studied 'double_formatter_t' well enough to be
sure I've done this correctly.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]