lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 21d847fb 1/4: Fix defect introduced 20220623T


From: Greg Chicares
Subject: [lmi-commits] [lmi] master 21d847fb 1/4: Fix defect introduced 20220623T0010Z: uninitialized make variable
Date: Mon, 20 Mar 2023 18:19:35 -0400 (EDT)

branch: master
commit 21d847fbcf4f180837a4f88473ab4c0b576e23ca
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Fix defect introduced 20220623T0010Z: uninitialized make variable
    
    Commit adc56d256ff8a of 20220623T0010Z moved code that depended on
    the value of $(this_makefile) from a makefile that defined it to one
    that didn't. Due to subsequent changes, the list of warning flags and
    the 'show_overlooked_cxx_warnings' target reside in two different
    makefiles, so the simple idea of initializing $(this_makefile) would
    be incorrect.
---
 compiler_gcc.make | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/compiler_gcc.make b/compiler_gcc.make
index 1123ee93..3cba2e29 100644
--- a/compiler_gcc.make
+++ b/compiler_gcc.make
@@ -340,6 +340,8 @@ ALL_LDFLAGS  = $(REQUIRED_LDFLAGS)  $(LDFLAGS)
 ALL_ARFLAGS  = $(REQUIRED_ARFLAGS)  $(ARFLAGS)
 ALL_RCFLAGS  = $(REQUIRED_RCFLAGS)  $(RCFLAGS)
 
+warnings_makefile := $(srcdir)/compiler_gcc_warnings.make
+
 # For the /dev/null rationale, see:
 #   https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91011#c7
 
@@ -349,5 +351,5 @@ show_overlooked_cxx_warnings:
          | $(GREP) '[[]disabled[]]' \
          | $(SED) -e's/[ \t]*[[]disabled[]]//' -e's/^ *-W//' \
          > eraseme
-       @$(GREP) -of eraseme $(this_makefile) | $(GREP) -vxf - eraseme || true
+       @$(GREP) -of eraseme $(warnings_makefile) | $(GREP) -vxf - eraseme || 
true
        @$(RM) eraseme



reply via email to

[Prev in Thread] Current Thread [Next in Thread]