[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 3dc4f293 2/3: Note a refactoring opportunity
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 3dc4f293 2/3: Note a refactoring opportunity |
Date: |
Fri, 13 May 2022 20:13:14 -0400 (EDT) |
branch: master
commit 3dc4f293f27a5f1197cab86d36af357e87fd1764
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
Note a refactoring opportunity
---
ihs_irc7702a.cpp | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/ihs_irc7702a.cpp b/ihs_irc7702a.cpp
index 9a2c1cb6..547c0b6a 100644
--- a/ihs_irc7702a.cpp
+++ b/ihs_irc7702a.cpp
@@ -1298,6 +1298,15 @@ and
// have more than eight decimals in practice; perform the
// multiplication this way to avoid embarrassments like the
// example in commit a91cbc67d7479e.
+ //
+ // Something like this could be done if adjusted_bft were currency:
+// [assert or test Use7PPTable]
+// SevenPP = rate_times_currency
+// (Saved7PPRate
+// ,round_somehow.c(adjusted_bft)
+// ,RoundNonMecPrem
+// );
+// [but it is better not to round internal variable SevenPP at all]
constexpr double radix {1.0e8};
// Do not save and restore prior rounding direction because
// lmi generally expects rounding to nearest everywhere.