[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 0100f71 2/8: Expunge a footling defect marker
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 0100f71 2/8: Expunge a footling defect marker [281] |
Date: |
Tue, 25 May 2021 20:10:59 -0400 (EDT) |
branch: master
commit 0100f71d7e6aad1d40efc744e245672f81498f64
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
Expunge a footling defect marker [281]
The same value is used in 'ihs_avsolve.cpp':
// No amount solved for can plausibly reach one billion dollars.
double upper_bound = 999999999.99;
and it is appropriate to make the same comment here. The use of an
arbitrary upper bound with an algorithm that requires that such a
bound be specified is no defect.
---
gpt_specamt.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gpt_specamt.cpp b/gpt_specamt.cpp
index a09d012..613af48 100644
--- a/gpt_specamt.cpp
+++ b/gpt_specamt.cpp
@@ -156,8 +156,7 @@ currency gpt_specamt::CalculateSpecAmt
,a_NetPmtFactorExc
);
- // TODO ?? The upper bound ideally wouldn't be hard coded; but if
- // it must be, then it can't plausibly reach one billion dollars.
+ // No amount solved for can plausibly reach one billion dollars.
decimal_root
(0.0
,999999999.99
- [lmi-commits] [lmi] master updated (ad8e4f7 -> f9d13e6), Greg Chicares, 2021/05/25
- [lmi-commits] [lmi] master 0100f71 2/8: Expunge a footling defect marker [281],
Greg Chicares <=
- [lmi-commits] [lmi] master 1966a5d 1/8: Force InitBaseSpecAmt to equal SpecAmt.front(), Greg Chicares, 2021/05/25
- [lmi-commits] [lmi] master 87ac2f8 3/8: Use product minimum for certain specamt strategies, Greg Chicares, 2021/05/25
- [lmi-commits] [lmi] master 2282f65 7/8: Explain an alteration of Brent's algorithm, Greg Chicares, 2021/05/25
- [lmi-commits] [lmi] master e85193a 6/8: Clarify, Greg Chicares, 2021/05/25
- [lmi-commits] [lmi] master 83a7960 5/8: Eliminate a side-effect guarantee [280], Greg Chicares, 2021/05/25
- [lmi-commits] [lmi] master f9d13e6 8/8: Refactor, Greg Chicares, 2021/05/25
- [lmi-commits] [lmi] master 17b7458 4/8: Eliminate the only use of a side-effect guarantee, Greg Chicares, 2021/05/25