[lmi-commits] [lmi] master 0ed65f7 28/28: Restore (commented out) a test that failed spectacularly

[Greg Chicares]

branch: master
commit 0ed65f700ac50d75a04ff016547b8c085e83bb16
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Restore (commented out) a test that failed spectacularly
    
    The failure was so spectacular that it might indicate a deeper problem
    that cannot be investigated today--so kept it, at least as a comment.
    
    Incidentally elaborated on some similar comments.
---
 path_utility_test.cpp | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/path_utility_test.cpp b/path_utility_test.cpp
index acfedcf..3c71337 100644
--- a/path_utility_test.cpp
+++ b/path_utility_test.cpp
@@ -415,7 +415,19 @@ void test_path_validation()
     // semantic validity is not considered, and any syntactically
     // valid path is well formed. Therefore, shouldn't the lmi
     // 'validate_*' functions test semantic validity? If not, the
-    // next two tests are senseless.
+    // next three tests are senseless (the first is already suppressed
+    // because it seems to indicate an 'alarum' problem).
+
+#if 0
+    // Neither posix nor msw allows a path to consist solely of NUL.
+    // BOOST !! Fix the 'alarum' problem.
+    std::string nulls = {'\0', '\0'};
+    LMI_TEST_THROW
+        (validate_filepath(nulls, context)
+        ,std::runtime_error
+        ,"Unit test file '' not found."
+        );
+#endif // 0
 
     // Neither posix nor msw allows NUL in paths.
     std::string with_nulls = {'x', '\0', 'y', '\0', 'z'};
@@ -424,7 +436,8 @@ void test_path_validation()
     // truncated at the first NUL, due to using std::runtime_error::what(),
     // which returns "char*" string terminated by the first NUL occurring in
     // it, when constructing this message, so just check that it starts with
-    // the expected part.
+    // the expected part. BOOST !! Of course, that's just an expedient
+    // workaround; the defect in 'alarum' needs to be fixed.
     LMI_TEST_THROW
         (validate_filepath(with_nulls, context)
         ,std::runtime_error
@@ -432,6 +445,10 @@ void test_path_validation()
         );
 
     // Posix doesn't forbid these characters, though msw does.
+    // But of course the test only made sense for the boost
+    // implementation, which treated "<|>" as ill-formed; it's
+    // senseless now because std::filesystem::path treats any
+    // path as well-formed.
     LMI_TEST_THROW
         (validate_filepath("<|>", context)
         ,std::runtime_error