[lmi-commits] [lmi] master 191757a: Another work around for spurious GUI test failures in CI builds

[Vadim Zeitlin]

branch: master
commit 191757ae44d42645789ff70ef350acbe7fd5cd12
Author: Vadim Zeitlin <vadim@tt-solutions.com>
Commit: Vadim Zeitlin <vadim@tt-solutions.com>

    Another work around for spurious GUI test failures in CI builds
    
    Try adding an extra delay on top of the wait loop added in 87a7956f3
    (Wait for Xvfb to become available before running the GUI test,
    2021-04-16) as we still get Wine nodrv_CreateWindow errors when trying
    to use Xvfb even when connecting to it already works.
    
    This is ugly, but there doesn't seem to be any way of checking if using
    Xvfb already works other than building and launching a test program just
    for this, which looks like an overkill -- but will still probably be the
    next step, if even this delay proves to be insufficient.
---
 .github/workflows/ci.yml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 64bc4aa..1c48c5b 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -303,6 +303,11 @@ jobs:
             num_tries=1
             while true; do
                 if xset -d :10 -q >/dev/null 2>&1; then
+                    echo 'Xvfb has become available.'
+                    # Trying to use it immediately can still result in errors
+                    # when creating the windows, somehow, so give it some time
+                    # to settle.
+                    sleep 3
                     break
                 fi
 
@@ -315,5 +320,5 @@ jobs:
                 echo "Still waiting for Xvfb (attempt #$num_tries)"
                 sleep 3
             done
-            echo 'Xvfb seems to be available, launching the test.'
+            echo 'Launching the GUI test:'
             DISPLAY=:10 ./gui_test.sh