[lmi-commits] [lmi] master 997d4d0 5/7: Do away with unused return value #4

[Greg Chicares]

branch: master
commit 997d4d0117679da1a4a76e8bedaff1de4c2df22a
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Do away with unused return value #4
---
 account_value.hpp | 2 +-
 accountvalue.cpp  | 7 ++-----
 ihs_acctval.cpp   | 7 ++-----
 3 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/account_value.hpp b/account_value.hpp
index eb68d73..45f78f6 100644
--- a/account_value.hpp
+++ b/account_value.hpp
@@ -131,7 +131,7 @@ class LMI_SO AccountValue final
     LedgerVariant  & VariantValues  ();
 
     double RunOneCell              (mcenum_run_basis);
-    double RunOneBasis             (mcenum_run_basis);
+    void   RunOneBasis             (mcenum_run_basis);
     void   RunAllApplicableBases   ();
     void   InitializeLife          (mcenum_run_basis);
     void   FinalizeLife            (mcenum_run_basis);
diff --git a/accountvalue.cpp b/accountvalue.cpp
index e2071f5..079d38d 100644
--- a/accountvalue.cpp
+++ b/accountvalue.cpp
@@ -148,21 +148,18 @@ void AccountValue::RunAV()
 }
 
 //============================================================================
-double AccountValue::RunOneBasis(mcenum_run_basis TheBasis)
+void AccountValue::RunOneBasis(mcenum_run_basis TheBasis)
 {
-    double z;
     if(Solving)
         {
         // IHS !! Isn't this unreachable?
         throw std::logic_error("This line had seemed to be unreachable.");
 //        LMI_ASSERT(TheBasis corresponds to 
yare_input_.SolveExpenseGeneralAccountBasis);
-//        z = Solve();
         }
     else
         {
-        z = RunOneCell(TheBasis);
+        RunOneCell(TheBasis);
         }
-    return z;
 }
 
 //============================================================================
diff --git a/ihs_acctval.cpp b/ihs_acctval.cpp
index f64c511..248165f 100644
--- a/ihs_acctval.cpp
+++ b/ihs_acctval.cpp
@@ -225,7 +225,7 @@ void AccountValue::SetGuarPrem()
 }
 
 //============================================================================
-double AccountValue::RunOneBasis(mcenum_run_basis a_Basis)
+void AccountValue::RunOneBasis(mcenum_run_basis a_Basis)
 {
     if
         (  !BasicValues::IsSubjectToIllustrationReg()
@@ -238,20 +238,17 @@ double AccountValue::RunOneBasis(mcenum_run_basis a_Basis)
             ;
         }
 
-    double z = 0.0;
     if(Solving)
         {
 // Apparently this should never be done because Solve() is called in
 //   RunAllApplicableBases() .
 // TODO ?? Isn't this unreachable?
 //      LMI_ASSERT(a_Basis corresponds to 
yare_input_.SolveExpenseGeneralAccountBasis);
-//      z = Solve();
         }
     else
         {
-        z = RunOneCell(a_Basis);
+        RunOneCell(a_Basis);
         }
-    return z;
 }
 
 //============================================================================