[lmi-commits] [lmi] master 50966de: Improve a throwaway script

[Greg Chicares]

branch: master
commit 50966de56eb72a710191e8e64fa0d84a88116355
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Improve a throwaway script
---
 gwc/foo | 22 +++++++++-------------
 1 file changed, 9 insertions(+), 13 deletions(-)

diff --git a/gwc/foo b/gwc/foo
index ee815d9..8fe88c0 100755
--- a/gwc/foo
+++ b/gwc/foo
@@ -1,32 +1,28 @@
 #!/bin/sh
 
-set -vx
+# set -vx
 
 CHROOT_USERS=$(getent group "lmi" | cut -d':' -f4 | tr ',' ' ')
-#CHROOT_UIDS=
+CHROOT_UIDS=
 for u in ${CHROOT_USERS}; do
   echo "${u}" "$(id -u "${u}")"
   CHROOT_UIDS="${CHROOT_UIDS} $(id -u "${u}")"
 done
+# Remove leading delimiter.
 CHROOT_UIDS=$(echo "${CHROOT_UIDS}" | sed -e's/^ //')
 echo "'${CHROOT_USERS}'"
 echo "'${CHROOT_UIDS}'"
 
-i=0
-for i in 1 2 3 4; do
-  echo "${CHROOT_UIDS}" | cut -d' ' -f"${i}"
-done
-
-echo "${CHROOT_UIDS}" | cut -d' ' -f1
-echo "${CHROOT_UIDS}" | cut -d' ' -f2
-echo "${CHROOT_UIDS}" | cut -d' ' -f3
-echo "${CHROOT_UIDS}" | cut -d' ' -f4
-
 i=1
-while [ "$i" -ne 10 ]
+while true
 do
   uid=$(echo "${CHROOT_UIDS}" | cut -d' ' -f"${i}")
   user=$(echo "${CHROOT_USERS}" | cut -d' ' -f"${i}")
+  if [ -z "$user" ] && [ -z "$uid" ] ; then break; fi
+  if [ -z "$user" ] || [ -z "$uid" ] ; then
+    printf 'Problem: both "%s" and "%" must be nonempty.\n' "$user" "$uid"
+    break
+  fi
   printf '  user %i: name %s; uid %i\n' "$i" "$user" "$uid"
   i=$((i + 1))
 done