[lmi-commits] [lmi] master b9adeb4 08/10: Consolidate and simplify '-Wno-' options for cgicc

[Greg Chicares]

branch: master
commit b9adeb43ba648098c418b30196ab2c8d91021f40
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Consolidate and simplify '-Wno-' options for cgicc
    
    Now that there's a set of warning options for cgicc sources, it makes
    no sense to specify similar options elsewhere for specific source files
    in that set. Removed '-Wno-sign-conversion', which has perhaps been made
    unnecessary by '-isystem' usage.
    
    It might be stricter to specify
      -Wno-conversion -Wfloat-conversion
    as is done elsewhere in this makefile, apparently on the theory that
      -Wconversion enables -Wfloat-conversion
    and therefore perhaps
      -Wno-conversion implies -Wno-float-conversion (?)
    in which case '-Wfloat-conversion' might need to be specifically
    enabled. The documentation isn't necessarily clear on this point. But
    it seems needless to worry about floating-point conversions in cgicc.
---
 workhorse.make | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/workhorse.make b/workhorse.make
index 60fd891..46c23d3 100644
--- a/workhorse.make
+++ b/workhorse.make
@@ -588,6 +588,7 @@ $(boost_regex_objects): gcc_common_extra_warnings += \
   -Wno-zero-as-null-pointer-constant \
 
 $(cgicc_objects): gcc_common_extra_warnings += \
+  -Wno-conversion \
   -Wno-zero-as-null-pointer-constant \
 
 expression_template_0_test.o: gcc_common_extra_warnings += \
@@ -634,8 +635,6 @@ $(xmlwrapp_objects): gcc_common_extra_warnings += \
 # SOMEDAY !! Address some of these '-Wconversion' issues.
 
 wno_conv_objects := \
-  CgiUtils.o \
-  FormEntry.o \
   currency_test.o \
   rate_table.o \
   round_glibc.o \
@@ -648,8 +647,6 @@ wno_sign_conv_objects := \
   $(boost_filesystem_objects) \
   $(boost_regex_objects) \
   $(wx_dependent_objects) \
-  CgiEnvironment.o \
-  CgiUtils.o \
   crc32.o \
   getopt.o \
   md5.o \