[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 768ce8a 3/4: Fix defect introduced 20141010T1
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 768ce8a 3/4: Fix defect introduced 20141010T1722Z: obsoleted comments kept |
Date: |
Thu, 30 Apr 2020 15:38:44 -0400 (EDT) |
branch: master
commit 768ce8afdc70b94c0cd8703025c67727615b5e22
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Fix defect introduced 20141010T1722Z: obsoleted comments kept
Commit f38062d4c69 of 20141010T1722Z fixed the defect that prevented
LMI_ASSERT_EQUAL(1&1,1&1);
from compiling, but failed to remove comments stating that it fails to
compile.
---
assert_lmi_test.cpp | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/assert_lmi_test.cpp b/assert_lmi_test.cpp
index 9568395..76ca5b1 100644
--- a/assert_lmi_test.cpp
+++ b/assert_lmi_test.cpp
@@ -50,10 +50,7 @@ int test_main(int, char*[])
LMI_ASSERT(!not_true);
// This use-case demonstrates why LMI_ASSERT_WITH_MSG's second
- // parameter is not token-pasted. This is a deliberate tradeoff,
- // with the consequence that this:
- // LMI_ASSERT_WITH_MSG(1&1,1&1);
- // fails to compile.
+ // parameter is not token-pasted.
BOOST_TEST_THROW
(LMI_ASSERT_WITH_MSG(not_true,"<" << not_true << ">")
,std::runtime_error
@@ -66,7 +63,8 @@ int test_main(int, char*[])
,"Assertion '(not_true) == (true)' failed\n(expected 1 vs observed
0)." LMI_LOCATION
);
- // It does seem wrong that this fails to compile:
+ // This test demonstrated a historical error: it failed to compile
+ // when arguments were not parenthesized in the macro.
LMI_ASSERT_EQUAL(1&1,1&1);
return 0;