lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 6b3b67f 1/5: Improve 'ls' output


From: Greg Chicares
Subject: [lmi-commits] [lmi] master 6b3b67f 1/5: Improve 'ls' output
Date: Tue, 28 Apr 2020 21:17:23 -0400 (EDT)

branch: master
commit 6b3b67f01b2113f64ed5b8bdd66863543e5aaa96
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Improve 'ls' output
    
    Here, 'ls -ld $(find .)' is preferable to 'ls -lR' because it gives a
    flat list of files, one file per line, making it easier to compare
    permissions between subdirectories. It does however require disabling
    shellcheck warning SC2046 (quoting really isn't wanted here).
    
    '(cd wherever && some_command)' is better than 'cd' (which makes a
    persistent change) or 'pushd wherever && some_command; popd' (which
    isn't POSIX).
---
 gwc/share_git1.sh | 6 ++++--
 gwc/share_git2.sh | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/gwc/share_git1.sh b/gwc/share_git1.sh
index 7765b32..7afb422 100755
--- a/gwc/share_git1.sh
+++ b/gwc/share_git1.sh
@@ -126,5 +126,7 @@ ls -ld $(find .) |sed -e'/ audio /d'
 
 # List all files' permissions for comparison, e.g.:
 #   meld /srv/chroot/bullseye0/tmp/eraseme/ls-* &
-cd /tmp/eraseme/"$inited" && ls -alR >/tmp/eraseme/ls-"$inited"
-cd /tmp/eraseme/"$cloned" && ls -alR >/tmp/eraseme/ls-"$cloned"
+# shellcheck disable=SC2046
+(cd "$inited" && ls -ld $(find .)) > ls-"$inited"
+# shellcheck disable=SC2046
+(cd "$cloned" && ls -ld $(find .)) > ls-"$cloned"
diff --git a/gwc/share_git2.sh b/gwc/share_git2.sh
index eec3178..013204e 100755
--- a/gwc/share_git2.sh
+++ b/gwc/share_git2.sh
@@ -130,5 +130,7 @@ ls -ld $(find .) |sed -e'/ audio /d'
 
 # List all files' permissions for comparison, e.g.:
 #   meld /srv/chroot/bullseye0/tmp/eraseme/ls-* &
-cd /tmp/eraseme/"$inited" && ls -alR >/tmp/eraseme/ls-"$inited"
-cd /tmp/eraseme/"$cloned" && ls -alR >/tmp/eraseme/ls-"$cloned"
+# shellcheck disable=SC2046
+(cd "$inited" && ls -ld $(find .)) > ls-"$inited"
+# shellcheck disable=SC2046
+(cd "$cloned" && ls -ld $(find .)) > ls-"$cloned"



reply via email to

[Prev in Thread] Current Thread [Next in Thread]