[lmi-commits] [lmi] master aedc8d0 11/14: Detect files that aren't group writable

[Greg Chicares]

branch: master
commit aedc8d04ad718e06908ef20049338627ae622a88
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Detect files that aren't group writable
---
 gwc/share_git1.sh | 14 ++++++++++++--
 gwc/share_git2.sh | 14 ++++++++++++--
 2 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/gwc/share_git1.sh b/gwc/share_git1.sh
index 026ce71..2eedbda 100755
--- a/gwc/share_git1.sh
+++ b/gwc/share_git1.sh
@@ -45,7 +45,7 @@ git -C "$inited" remote add origin 
https://github.com/wxWidgets/zlib.git
 git -C "$inited" fetch origin
 
 find ./"$inited" ! -perm -g=w |sed -e'/objects\/pack/d'
-# Oops: FETCH_HEAD doesn't have group permissions:
+# Oops: FETCH_HEAD doesn't have group write permissions:
 ls -l ./"$inited"/*HEAD
 
 # This isn't really necessary; it just makes the result look more like
@@ -92,7 +92,7 @@ ls -l ./"$cloned"/*HEAD
 git -C "$cloned" fetch
 
 find ./"$cloned" ! -perm -g=w |sed -e'/objects\/pack/d'
-# Oops: FETCH_HEAD doesn't have group permissions:
+# Oops: FETCH_HEAD doesn't have group write permissions:
 ls -l ./"$cloned"/*HEAD
 
 # This fails:
@@ -115,6 +115,16 @@ du -sb "$cloned" "$inited"
 git -C "$cloned" fsck
 git -C "$inited" fsck
 
+# Show any files that aren't group writable, expecting '.' only.
+#
+# Something like this:
+#   stat --printf="%A %a\t%U %G %n\n" $(find .) |sed ...
+# could be used instead of 'ls', but the gain in robustness doesn't
+# seem worth the loss in readability.
+# shellcheck disable=SC2012
+# shellcheck disable=SC2046
+ls -ld $(find .) |sed -e'/^.....w/d' -e'/objects\/pack/d'
+
 # List all files' permissions for comparison, e.g.:
 #   meld /srv/chroot/bullseye0/tmp/eraseme/ls-* &
 cd /tmp/eraseme/"$inited" && ls -alR >/tmp/eraseme/ls-"$inited"
diff --git a/gwc/share_git2.sh b/gwc/share_git2.sh
index 8519fa2..d4f13fb 100755
--- a/gwc/share_git2.sh
+++ b/gwc/share_git2.sh
@@ -49,7 +49,7 @@ git -C "$inited" remote add origin 
https://github.com/wxWidgets/zlib.git
 git -C "$inited" fetch origin
 
 find ./"$inited" ! -perm -g=w |sed -e'/objects\/pack/d'
-# Oops: FETCH_HEAD doesn't have group permissions:
+# Oops: FETCH_HEAD doesn't have group write permissions:
 ls -l ./"$inited"/.git/*HEAD
 
 # This isn't really necessary; it just makes the result look more like
@@ -96,7 +96,7 @@ ls -l ./"$cloned"/.git/*HEAD
 git -C "$cloned" fetch
 
 find ./"$cloned" ! -perm -g=w |sed -e'/objects\/pack/d'
-# Oops: FETCH_HEAD doesn't have group permissions:
+# Oops: FETCH_HEAD doesn't have group write permissions:
 ls -l ./"$cloned"/.git/*HEAD
 
 # This fails:
@@ -116,6 +116,16 @@ du -sb "$cloned" "$inited"
 git -C "$cloned" fsck
 git -C "$inited" fsck
 
+# Show any files that aren't group writable, expecting '.' only.
+#
+# Something like this:
+#   stat --printf="%A %a\t%U %G %n\n" $(find .) |sed ...
+# could be used instead of 'ls', but the gain in robustness doesn't
+# seem worth the loss in readability.
+# shellcheck disable=SC2012
+# shellcheck disable=SC2046
+ls -ld $(find .) |sed -e'/^.....w/d' -e'/objects\/pack/d'
+
 # List all files' permissions for comparison, e.g.:
 #   meld /srv/chroot/bullseye0/tmp/eraseme/ls-* &
 cd /tmp/eraseme/"$inited" && ls -alR >/tmp/eraseme/ls-"$inited"