[lmi-commits] [lmi] master e1520a8: Remove an unnecessary chmod command

[Greg Chicares]

branch: master
commit e1520a8373b7a0da345058f8aa5b84bef1e502ec
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Remove an unnecessary chmod command
    
    See:
      https://lists.nongnu.org/archive/html/lmi/2020-03/msg00003.html
    
    If an actual need for this is someday found, consider instead:
    
    -   $(CHMOD) 750 $(cache_dir)/$@
    +   [ -x $(cache_dir)/$@ ] || $(CHMOD) 750 $(cache_dir)/$@
    
    which will succeed if the file is cached and is executable, even if
    someone else owns it and chmod therefore cannot be called.
---
 install_miscellanea.make | 2 --
 1 file changed, 2 deletions(-)

diff --git a/install_miscellanea.make b/install_miscellanea.make
index 69d68f6..556f27e 100644
--- a/install_miscellanea.make
+++ b/install_miscellanea.make
@@ -86,7 +86,6 @@ $(xmlwrapp_archive)-md5 := 5e8ac678ab03b7c60ce61ac5424e0849
 
 # Utilities 
####################################################################
 
-CHMOD  := chmod
 CP     := cp
 DIFF   := diff
 ECHO   := echo
@@ -274,7 +273,6 @@ WGETFLAGS := --no-check-certificate --no-verbose
 %.exe:
        cd $(cache_dir) && [ -e $@ ] || $(WGET) $(WGETFLAGS) $($@-url)
        $(ECHO) "$($@-md5) *$(cache_dir)/$@" | $(MD5SUM) --check
-       $(CHMOD) 750 $(cache_dir)/$@
 
 .PHONY: %.zip
 %.zip: