[lmi-commits] [lmi] master 7f4cda3 2/5: Induce failure in istream extractor more portably

[Greg Chicares]

branch: master
commit 7f4cda3fcc81693da1b359167ee84651c7e24853
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Induce failure in istream extractor more portably
    
    This is known to work as expected with all compilers tested--see:
      https://lists.nongnu.org/archive/html/lmi/2020-01/msg00011.html
---
 stream_cast_test.cpp | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/stream_cast_test.cpp b/stream_cast_test.cpp
index c4562e5..430c9f7 100644
--- a/stream_cast_test.cpp
+++ b/stream_cast_test.cpp
@@ -75,7 +75,7 @@ int test_main(int, char*[])
     // Induce failure in ostream inserter:
     std::stringstream ss0;
     ss0 << static_cast<std::streambuf*>(nullptr);
-    BOOST_TEST(std::ios_base::badbit == ss0.rdstate());
+    BOOST_TEST(!ss0);
     BOOST_TEST_THROW
         (stream_cast<std::string>(static_cast<std::streambuf*>(nullptr))
         ,std::runtime_error
@@ -84,19 +84,13 @@ int test_main(int, char*[])
 
     // Induce failure in istream extractor:
     std::stringstream ss1;
-    ss1 << "INF";
-    BOOST_TEST(std::ios_base::goodbit == ss1.rdstate());
-    double d {0};
-    ss1 >> d;
-    // This test is defective. With clang, the stream state is good.
-    // With gcc, failbit is set, but apparently that's because gcc
-    // rejects the characters 'I' and 'N'--see:
-    //   https://lists.nongnu.org/archive/html/lmi/2020-01/msg00010.html
-    //   https://cplusplus.github.io/LWG/lwg-active.html#2381
-std::cout << ss1.rdstate() << std::endl;
-    BOOST_TEST(std::ios_base::failbit == ss1.rdstate());
+    ss1 << "3";
+    BOOST_TEST(! !ss1);
+    bool b {0};
+    ss1 >> b;
+    BOOST_TEST(!ss1);
     BOOST_TEST_THROW
-        (stream_cast<double>("INF")
+        (stream_cast<bool>("3")
         ,std::runtime_error
         ,lmi_test::what_regex("^Output failed")
         );