[lmi-commits] [lmi] master 95095d9 2/4: Reduce obscurity

[Greg Chicares]

branch: master
commit 95095d9d4939cf93f677e4e5c95dbf7b1245f7f4
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Reduce obscurity
    
    This "include" file is to be sourced, so it needn't 'export' the
    variables it sets; in particular, it shouldn't export only one of
    several variables. The original idea was to avoid SC2034: it seemed
    at first that writing 'export' was less obtrusive and unnatural than
    adding a shellcheck directive; but exporting only one of three
    variables now seems more unnatural, and the tersest comment capable
    of explaining it is the shellcheck directive (which alone was not
    previously sufficient because it was misplaced).
---
 lmi_setup_inc.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lmi_setup_inc.sh b/lmi_setup_inc.sh
index 12d2f6c..432dd93 100755
--- a/lmi_setup_inc.sh
+++ b/lmi_setup_inc.sh
@@ -25,12 +25,11 @@
 # CHRTVER : local serial number (nothing to do with /etc/debian_version)
 # CHRTNAME: physical name of chroot (SCHROOT_CHROOT_NAME)
 
+# shellcheck disable=SC2034
+#   (this file should only be sourced)
 CODENAME=bullseye
 CHRTVER=eraseme
 CHRTNAME=lmi_${CODENAME}${CHRTVER}
-# shellcheck disable=SC2034
-#   (this file should only be sourced)
-export CHRTNAME
 
 assert_su()
 {