[lmi-commits] [lmi] master 9b9978f 16/18: Avoid 'ls --classify'

[Greg Chicares]

branch: master
commit 9b9978fcb6b1c6a7656530f06743010a525a6d66
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Avoid 'ls --classify'
---
 GNUmakefile | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/GNUmakefile b/GNUmakefile
index 8406bca..17a3c17 100644
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -421,7 +421,7 @@ custom_tools:
 # Either of these suggests a build failure that may render dependency
 # files invalid; 'make clean' should provide symptomatic relief.
 #
-# The '$(LS) --classify' test somewhat loosely identifies source files
+# The "find ... '*.sed'" test somewhat loosely identifies source files
 # whose executable bit is improperly set. It is properly set iff the
 # file starts with a hash-bang; to avoid the cost of opening every
 # file, a simple heuristic is used, '*.sh *.sed' being the only files
@@ -451,10 +451,12 @@ check_concinnity: source_clean custom_tools
          | $(MD5SUM) --check --quiet || true
        @for z in $(build_dir)/*.d; do [ -s $$z ]         || echo $$z; done;
        @for z in $(build_dir)/*.o; do [ -f $${z%%.o}.d ] || echo $$z; done;
-       @$(LS) --classify $(prefascicle_dir)/* \
-         | $(SED) -e'/\*$$/!d' -e'/^\.\//!d' -e'/.sh\*$$/d' -e'/.sed\*$$/d' \
+       @find $(prefascicle_dir) -maxdepth 1 -executable -type f \
+         -not -name '*.sh' -not -name '*.sed' \
+         -not -name 'commit-msg' -not -name 'pre-commit' \
          | $(SED) -e's/^/Improperly executable: /'
-       @find $(prefascicle_dir) -executable -type f -print0 | xargs -0 -n 1 -P 
0 ./check_script.sh
+       @find $(prefascicle_dir) -executable -type f -print0 \
+         | xargs -0 -n 1 -P 0 ./check_script.sh
        @$(ECHO) "  Problems detected by xmllint:"
        @for z in $(xml_files); \
          do \