lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 9a36758 1/6: Rewrite for clarity


From: Greg Chicares
Subject: [lmi-commits] [lmi] master 9a36758 1/6: Rewrite for clarity
Date: Sun, 19 May 2019 19:29:18 -0400 (EDT)

branch: master
commit 9a36758ae8bdedad8687ebd360896c2039d07fda
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Rewrite for clarity
    
    There is no need for a phony target with a static name to create a file
    with a dynamic name. It is clearer to write a non-phony target that
    generates the file directly.
---
 GNUmakefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/GNUmakefile b/GNUmakefile
index 1f143f7..cf66057 100644
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -136,12 +136,11 @@ touchstone_dir  := $(prefix)/touchstone
 
 export LMI_ENV_FILE := env_$(shell date -u +'%s_%N').eraseme
 
-GNUmakefile $(srcdir)/GNUmakefile:: source_env_vars
+GNUmakefile $(srcdir)/GNUmakefile:: $(LMI_ENV_FILE)
        $(eval include $(LMI_ENV_FILE))
        @rm $(LMI_ENV_FILE)
 
-.PHONY: source_env_vars
-source_env_vars:
+$(LMI_ENV_FILE):
        @. ./set_toolchain.sh
 
 # Included files that don't need to be remade are given explicit empty



reply via email to

[Prev in Thread] Current Thread [Next in Thread]