[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 9a36758 1/6: Rewrite for clarity
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 9a36758 1/6: Rewrite for clarity |
Date: |
Sun, 19 May 2019 19:29:18 -0400 (EDT) |
branch: master
commit 9a36758ae8bdedad8687ebd360896c2039d07fda
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Rewrite for clarity
There is no need for a phony target with a static name to create a file
with a dynamic name. It is clearer to write a non-phony target that
generates the file directly.
---
GNUmakefile | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/GNUmakefile b/GNUmakefile
index 1f143f7..cf66057 100644
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -136,12 +136,11 @@ touchstone_dir := $(prefix)/touchstone
export LMI_ENV_FILE := env_$(shell date -u +'%s_%N').eraseme
-GNUmakefile $(srcdir)/GNUmakefile:: source_env_vars
+GNUmakefile $(srcdir)/GNUmakefile:: $(LMI_ENV_FILE)
$(eval include $(LMI_ENV_FILE))
@rm $(LMI_ENV_FILE)
-.PHONY: source_env_vars
-source_env_vars:
+$(LMI_ENV_FILE):
@. ./set_toolchain.sh
# Included files that don't need to be remade are given explicit empty
- [lmi-commits] [lmi] master updated (3ff6c00 -> 97a8cf8), Greg Chicares, 2019/05/19
- [lmi-commits] [lmi] master 4849fae 5/6: Make sure $LMI_COMPILER and $LMI_TRIPLET are set, Greg Chicares, 2019/05/19
- [lmi-commits] [lmi] master 97a8cf8 6/6: Fix an observed problem, Greg Chicares, 2019/05/19
- [lmi-commits] [lmi] master 6b5f5b2 4/6: Rely on 'set_toolchain.sh' to set $LMI_COMPILER and $LMI_TRIPLET, Greg Chicares, 2019/05/19
- [lmi-commits] [lmi] master 995bf3e 2/6: Ensure existence of directory required by 'hooks/pre-commit', Greg Chicares, 2019/05/19
- [lmi-commits] [lmi] master 9a36758 1/6: Rewrite for clarity,
Greg Chicares <=
- [lmi-commits] [lmi] master e5172aa 3/6: Set $LMI_COMPILER and $LMI_TRIPLET to defaults if unset or null, Greg Chicares, 2019/05/19