lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] odd/multiarch 98e00a5 05/10: Explain why one variabl


From: Greg Chicares
Subject: [lmi-commits] [lmi] odd/multiarch 98e00a5 05/10: Explain why one variable is unset while another is exported
Date: Wed, 15 May 2019 17:59:55 -0400 (EDT)

branch: odd/multiarch
commit 98e00a50202ccf6e1e052b2564d091ebffc4c8c2
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Explain why one variable is unset while another is exported
---
 set_arch.sh | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/set_arch.sh b/set_arch.sh
index 95d4c18..ac25d7d 100755
--- a/set_arch.sh
+++ b/set_arch.sh
@@ -107,7 +107,13 @@ local  winebindir="$prefix"/third_party/bin
 minimal_path=${MINIMAL_PATH:-"/usr/bin:/bin:/usr/sbin:/sbin"}
 export PATH="$localbindir":"$locallibdir":"$minimal_path"
 
+# It is appropriate to unset $WINEPATH because no lmi script ever uses
+# it directly--it's implicitly used, only by 'wine'. OTOH, $PERFORM is
+# used directly, so it's always exported, even if empty--though that's
+# probably just a matter of taste.
+
 unset -v WINEPATH
+export PERFORM
 
 # Are double quotes inside double quotes inside $() dubious? I.e.,
 #  " $( "is this string quoted?" ) "
@@ -131,9 +137,7 @@ case "$lmi_build_type" in
         export WINEPATH="$w0;$w1;$w2"
         export  PERFORM="wine"
         ;;
-    (*)
-        export PERFORM
-        ;;
+    (*) ;;
 esac
 }
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]