[lmi-commits] [lmi] odd/fixups 880f1a7 4/4: Add a text file with some notes

[Greg Chicares]

branch: odd/fixups
commit 880f1a779c1a0be6fb16804d82efed5d27534cb4
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Add a text file with some notes
---
 NOTES.txt | 61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 61 insertions(+)

diff --git a/NOTES.txt b/NOTES.txt
new file mode 100644
index 0000000..d23563b
--- /dev/null
+++ b/NOTES.txt
@@ -0,0 +1,61 @@
+My email is down, but my correspondents are clever enough to look here.
+
+Commits on this temporary branch:
+
+953b23ea (HEAD -> odd/fixups) cp slash dot, not slash asterisk
+62473f9f 'cp' a directory's contents (only)
+45e7da7a Replace literal "gcc" with $LMI_COMPILER
+caf6f550 (xanadu/master, origin/master, origin/HEAD, master) Guard against 
unit-test failures
+
+In detail:
+
+  45e7da7a Replace literal "gcc" with $LMI_COMPILER
+
+I think this will be necessary to distinguish, e.g., gcc from clang.
+We may as well make this change now while we're testing everything.
+
+  62473f9f 'cp' a directory's contents (only)
+
+The commit message explains this in detail. My question is whether
+'/path/to/.' is preferable to '/path/to/*' as a general rule.
+
+  953b23ea (HEAD -> odd/fixups) cp slash dot, not slash asterisk
+The typical advice online favors '/path/to/.'. If that's preferable
+here, then it must be preferable everywhere. But this is a big scary
+change, so I wanted to run some tests.
+
+In a directory with many files...
+
+/opt/lmi/src/lmi[0]$ls * |wc -l
+804
+
+/opt/lmi/src/lmi[0]$for z in ./* ; do echo $z; done |wc -l
+754
+/opt/lmi/src/lmi[0]$for z in ./. ; do echo $z; done |wc -l
+1
+
+/opt/lmi/src/lmi[0]$for z in ./. ; do echo $z; done
+./.
+
+This leads me to doubt very much that 953b23ea was a good idea,
+and therefore to think that an asterisk would be better in 62473f9f.
+
+Thus, I would propose to commit 45e7da7a and the following:
+
+---------8<--------8<--------8<--------8<--------8<--------8<--------8<-------
+diff --git a/install_mingw.make b/install_mingw.make
+index 21de260e..452d48b5 100644
+--- a/install_mingw.make
++++ b/install_mingw.make
+@@ -105,7 +105,7 @@ ad_hoc_dir_exists = \
+ 
+ .PHONY: all
+ all: $(file_list)
+-       $(CP) --archive $(ad_hoc_dir)/mingw32 $(prefix)
++       $(CP) --archive $(ad_hoc_dir)/mingw32/* $(prefix)
+        $(RM) --force --recursive $(ad_hoc_dir)
+ 
+ $(file_list): initial_setup
+--------->8-------->8-------->8-------->8-------->8-------->8-------->8-------
+
+to master, and then forcibly delete this branch.