lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 1430c70 03/10: Consolidate documentation


From: Greg Chicares
Subject: [lmi-commits] [lmi] master 1430c70 03/10: Consolidate documentation
Date: Fri, 27 Jul 2018 17:03:53 -0400 (EDT)

branch: master
commit 1430c702fba3c850615b1e4c1328ae45ec3595be
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Consolidate documentation
    
    Moved a comment about the design of class wx_table_generator out of
    compute_column_widths(), which will soon become a free function.
---
 wx_table_generator.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/wx_table_generator.cpp b/wx_table_generator.cpp
index d5e08c4..9b185a8 100644
--- a/wx_table_generator.cpp
+++ b/wx_table_generator.cpp
@@ -435,6 +435,9 @@ wxRect wx_table_generator::text_rect(std::size_t column, 
int y) const
 /// this class, even for "hidden" columns that are to be suppressed so
 /// that they don't appear in the output at all. This approach trades
 /// extra complexity here for a uniform data representation elsewhere.
+/// PDF !! Instead of retaining hidden columns, and explicitly skipping
+/// them here and repeatedly later (and in compute_column_widths()),
+/// consider removing them from the vector.
 ///
 /// Notice that column headers may be multiline strings.
 ///
@@ -541,8 +544,6 @@ void wx_table_generator::compute_column_widths()
 
     for(auto const& i : all_columns())
         {
-// Instead of retaining hidden columns, and explicitly skipping them
-// here and repeatedly later, why not just remove them from the vector?
         if(i.is_hidden())
             {
             continue;



reply via email to

[Prev in Thread] Current Thread [Next in Thread]