[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 21260f8 3/7: Rename a member function
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 21260f8 3/7: Rename a member function |
Date: |
Wed, 23 May 2018 21:18:25 -0400 (EDT) |
branch: master
commit 21260f89290e0f4be800d48525ab73769cf17364
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Rename a member function
Columns that are to be hidden are identified by is_hidden(). The
function identifying columns that are to be clipped has analogously
been renamed is_clipped(). Another uniform prefix could be used
(e.g., needs_hiding() or should_hide()), but 'is_' is simplest.
---
wx_table_generator.cpp | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/wx_table_generator.cpp b/wx_table_generator.cpp
index 47924d1..d3eba37 100644
--- a/wx_table_generator.cpp
+++ b/wx_table_generator.cpp
@@ -46,7 +46,7 @@
// All potential data are passed for every row; is_hidden() suppresses
// any column that needs to be filtered out.
//
-// - needs_clipping()
+// - is_clipped()
//
// And what sort of columns need to be clipped? As currently implemented,
// this function is equivalent to is_elastic()--i.e., only
@@ -71,7 +71,7 @@
// or narrower than their narrowest. As a consequence, elastic
// columns must be clipped if necessary.
//
-// - needs_clipping(): Indicate whether column contents need to be
+// - is_clipped(): Indicate whether column contents need to be
// clipped when outputting it. Only elastic columns are clippable:
// for example, personal names are of unbounded length and might
// even exceed the total page width. Inelastic columns, OTOH, have
@@ -95,12 +95,12 @@ class wx_table_generator::column_info
{
}
- std::string const& col_header() const {return col_header_;}
- int col_width() const {return col_width_;}
- oenum_h_align alignment() const {return alignment_;}
- bool is_hidden() const {return is_hidden_;}
- bool is_elastic() const {return is_elastic_;}
- bool needs_clipping() const {return is_elastic();}
+ std::string const& col_header() const {return col_header_;}
+ int col_width() const {return col_width_;}
+ oenum_h_align alignment() const {return alignment_;}
+ bool is_hidden() const {return is_hidden_;}
+ bool is_elastic() const {return is_elastic_;}
+ bool is_clipped() const {return is_elastic();}
private:
std::string const col_header_;
@@ -606,7 +606,7 @@ void wx_table_generator::do_output_single_row
break;
}
- if(ci.needs_clipping())
+ if(ci.is_clipped())
{
// It is assumed that the width of the "Participant" column
// on a group quote was initially zero, and then was expanded
- [lmi-commits] [lmi] master updated (716c729 -> 9f0eebc), Greg Chicares, 2018/05/23
- [lmi-commits] [lmi] master 15f8f62 1/7: Rename some local variables for concinnity, Greg Chicares, 2018/05/23
- [lmi-commits] [lmi] master 21260f8 3/7: Rename a member function,
Greg Chicares <=
- [lmi-commits] [lmi] master 149a288 6/7: Improve a local variable's name, Greg Chicares, 2018/05/23
- [lmi-commits] [lmi] master e4ec715 4/7: Rewrite documentation, Greg Chicares, 2018/05/23
- [lmi-commits] [lmi] master 151a1ea 2/7: Add missing period at end of sentence, Greg Chicares, 2018/05/23
- [lmi-commits] [lmi] master 9f0eebc 7/7: Rename certain local variables, Greg Chicares, 2018/05/23
- [lmi-commits] [lmi] master f1a98e0 5/7: Improve concinnity, Greg Chicares, 2018/05/23