[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 40a94aa 12/12: Explain why width of an elasti
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 40a94aa 12/12: Explain why width of an elastic column is initialized to zero |
Date: |
Tue, 22 May 2018 17:09:23 -0400 (EDT) |
branch: master
commit 40a94aae3d9c8fdf3be6f2ecfcfabd16da0d6e08
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Explain why width of an elastic column is initialized to zero
---
wx_table_generator.cpp | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/wx_table_generator.cpp b/wx_table_generator.cpp
index a255c3b..96a2ba7 100644
--- a/wx_table_generator.cpp
+++ b/wx_table_generator.cpp
@@ -284,6 +284,10 @@ void wx_table_generator::enroll_column(column_parameters
const& z)
// A hidden column's width must be initialized to zero, because
// other member functions calculate total width by accumulating
// the widths of all columns, whether hidden or not.
+ //
+ // An elastic column's width must be initialized to zero, because
+ // compute_column_widths() skips setting it when there's no room
+ // for any elastic column.
int width = 0;
if(oe_shown == z.visibility)
{
@@ -318,8 +322,7 @@ LMI_ASSERT(std::size_t(h / lh) == 1u +
count_newlines(z.header));
break;
case oe_elastic:
{
- // Set width to the special value of 0 for the elastic columns.
- width = 0;
+ ; // Do nothing: 'width' already initialized to zero.
}
break;
}
- [lmi-commits] [lmi] master updated (a1f29ab -> 40a94aa), Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master b219dd9 01/12: Note a possible future return-type change, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master b725bcb 05/12: Reorder PDF column parameters, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master 2c95260 07/12: Prefer 'switch' to 'if' for a two-valued enum, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master bd86afe 04/12: Shorten an enumerator's name, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master 9e1ac25 09/12: Fold a "ternary" conditional into a switch, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master 40a94aa 12/12: Explain why width of an elastic column is initialized to zero,
Greg Chicares <=
- [lmi-commits] [lmi] master 6b93e91 11/12: Remove an unneeded auxiliary function, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master b232274 02/12: Make column elasticity enumerative rather than boolean, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master 7e64de5 03/12: Make column alignment enumerative rather than boolean, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master e2e4ad6 08/12: Remove a temporary assertion that is no longer useful, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master 637d535 06/12: Rework PDF column formatting in terms of "elasticity", Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master 6076b33 10/12: Simplify code; rewrite documentation, Greg Chicares, 2018/05/22