[lmi-commits] [lmi] master a738b9f 7/7: Use identical variables identically

[Greg Chicares]

branch: master
commit a738b9f4c1ac7c12d054b8caa856cbc2764da7ef
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Use identical variables identically
    
    In some cases, 'pos_y_copy' was used one way:
      make a copy, use it immediately, then use the original
    and in other cases, another way:
      make a copy, use the original, restore the original, use the original
    Changed the latter cases to work the former way, for consistency.
---
 ledger_pdf_generator_wx.cpp | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/ledger_pdf_generator_wx.cpp b/ledger_pdf_generator_wx.cpp
index 5b58b3a..74ff28c 100644
--- a/ledger_pdf_generator_wx.cpp
+++ b/ledger_pdf_generator_wx.cpp
@@ -2234,11 +2234,10 @@ class page_with_basic_tabular_report : public 
page_with_tabular_report
             ("Using guaranteed charges"
             ,column_guar0_cash_surr_value
             ,column_separator_guar_curr0
-            ,pos_y
+            ,pos_y_copy
             ,output_mode
             );
 
-        pos_y = pos_y_copy;
         table_gen.output_super_header
             ("Using current charges"
             ,column_curr0_cash_surr_value
@@ -2687,7 +2686,7 @@ class reg_d_individual_irr_base : public 
page_with_tabular_report
             (interpolate_html(header_zero.str()).as_html()
             ,column_zero_cash_surr_value
             ,column_zero_irr_surr_value
-            ,pos_y
+            ,pos_y_copy
             ,output_mode
             );
 
@@ -2700,7 +2699,6 @@ class reg_d_individual_irr_base : public 
page_with_tabular_report
             << "Return*"
             ;
 
-        pos_y = pos_y_copy;
         table_gen.output_super_header
             (interpolate_html(header_nonzero.str()).as_html()
             ,column_nonzero_cash_surr_value