lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master e3c3d92 4/5: Resolve a marked defect [386]


From: Greg Chicares
Subject: [lmi-commits] [lmi] master e3c3d92 4/5: Resolve a marked defect [386]
Date: Tue, 13 Feb 2018 08:02:40 -0500 (EST)

branch: master
commit e3c3d922a36eb7cb9304d9bed69b0238d2561a92
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Resolve a marked defect [386]
    
    Apparently the only place where a messagebox ever segfaulted was in
    the code deleted here, which had been marked for deletion a year ago
    in commit 4d92a38 of 2017-02-15T23:46:56+00:00.
---
 census_view.cpp | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/census_view.cpp b/census_view.cpp
index c8f96e3..6f0b3d9 100644
--- a/census_view.cpp
+++ b/census_view.cpp
@@ -1687,25 +1687,6 @@ void CensusView::UponPasteCensus(wxCommandEvent&)
 
         while(std::getline(iss_line, token, '\t'))
             {
-#if 0 // expunge soon?
-            static std::string const space(" ");
-            if(std::string::npos == token.find_first_not_of(space))
-                {
-                warning()
-                    << "Line #" << current_line << ": "
-                    << " (" << line << ") "
-                    << "has a value that contains no non-blank characters. "
-                    << "Last valid value, if any: " << values.back()
-                    << LMI_FLUSH
-                    ;
-// TODO ?? It would be better to use alarum() instead of
-// warning() followed by alarum() with a short string, but
-// apparently that can segfault with very long strings. Is there
-// a limit on exception size that should be tested here? See:
-//   http://savannah.nongnu.org/bugs/?20240
-                alarum() << "Invalid input." << LMI_FLUSH;
-                }
-#endif // 0
             values.push_back(token);
             }
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]