[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master b1ab0fa 126/156: Leave a gap between upper fo
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master b1ab0fa 126/156: Leave a gap between upper footer part and main page contents |
Date: |
Tue, 30 Jan 2018 17:22:28 -0500 (EST) |
branch: master
commit b1ab0fa259e6e8341a77d238798a8e276edd3c50
Author: Vadim Zeitlin <address@hidden>
Commit: Vadim Zeitlin <address@hidden>
Leave a gap between upper footer part and main page contents
If the upper part of the footer is not empty, leave some space between
it and the main page contents as nothing separates them visually
otherwise (unlike the lower footer which is separated by a divider
line).
---
ledger_pdf_generator_wx.cpp | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/ledger_pdf_generator_wx.cpp b/ledger_pdf_generator_wx.cpp
index a24960c..0d172cf 100644
--- a/ledger_pdf_generator_wx.cpp
+++ b/ledger_pdf_generator_wx.cpp
@@ -989,6 +989,11 @@ class page_with_footer : public page
,interpolate_html("{{>" + upper_template + "}}")
,e_output_measure_only
);
+
+ // Leave a gap between the upper part of the footer and the main
+ // page contents to separate them in absence of a separator line
+ // which delimits the lower part.
+ footer_height += writer.dc().GetCharHeight();
}
footer_top_ = writer.get_page_bottom() - footer_height;
@@ -1003,14 +1008,18 @@ class page_with_footer : public page
auto const frame_horz_margin = writer.get_horz_margin();
auto const frame_width = writer.get_page_width();
+ auto& dc = writer.dc();
+
auto y = footer_top_;
auto const& upper_template = get_upper_footer_template_name();
if(!upper_template.empty())
{
+ y += dc.GetCharHeight();
+
y += writer.output_html
(frame_horz_margin
- ,footer_top_
+ ,y
,frame_width
,interpolate_html("{{>" + upper_template + "}}")
);
@@ -1023,8 +1032,6 @@ class page_with_footer : public page
,get_footer_lower_html(interpolate_html)
);
- auto& dc = writer.dc();
-
dc.SetPen(HIGHLIGHT_COL);
dc.DrawLine
(frame_horz_margin
- [lmi-commits] [lmi] master 6b3b5b2 054/156: Factor out illustration_table_generator from tabular_detail2_page, (continued)
- [lmi-commits] [lmi] master 6b3b5b2 054/156: Factor out illustration_table_generator from tabular_detail2_page, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master 23d26f8 055/156: Factor out reusable page_with_tabular_report class, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master f484622 044/156: Only show numeric summary if not in force, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master 67db94b 042/156: Implement more of numeric summary page, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master dbaf3c4 048/156: Render PDF illustrations in two passes, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master de9567e 152/156: Fix misplaced commas in ledger PDF generator code, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master 783befa 006/156: Add separate class for representing HTML contents, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master 8c5be11 128/156: Use proper types for get_two_column_header() parameters, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master 257ff4b 065/156: Add numeric summary table to PDF illustrations, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master ef38c9d 141/156: Revert the title map related changes, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master b1ab0fa 126/156: Leave a gap between upper footer part and main page contents,
Greg Chicares <=
- [lmi-commits] [lmi] master 940198c 059/156: Add numeric summary attachment page, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master b341a2a 061/156: Factor out using_illustration_table helper class, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master 1b46585 076/156: Use MarketingNameFootnote & StateMarketingImprimatur on cover page, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master 234cd39 012/156: Use custom font sizes to be closer to the existing illustrations, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master 956fcca 071/156: Change the second narrative summary page to use a template too, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master dbe5955 015/156: Factor out html_interpolator from pdf_illustration, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master 9665573 070/156: Change narrative summary page to use an external template, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master a629602 083/156: Use custom <scaled_image> HTML tag for the embedded images, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master b425030 082/156: Factor out html_cell_for_pdf_output from numeric_summary_table_cell, Greg Chicares, 2018/01/30
- [lmi-commits] [lmi] master d99576a 069/156: Change cover page to use an external template, Greg Chicares, 2018/01/30