[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master a736dc8 2/7: Do not paste certain invalid uni
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master a736dc8 2/7: Do not paste certain invalid unit tests to census |
Date: |
Fri, 24 Feb 2017 15:22:53 -0500 (EST) |
branch: master
commit a736dc817832be3ab054822441761c3bf93c6a6e
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Do not paste certain invalid unit tests to census
The first of these two changes removed a line that actually prevented
pasting "census" into a census, because improved error detection in
class InputSequence caused it to throw an exception. The second line
removed did not fulfill its stated purpose, which was to test a logic
error that is not present in production and thus cannot be simulated
by pasting a string into a census.
---
input_sequence_test.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/input_sequence_test.cpp b/input_sequence_test.cpp
index 733acc4..fcfa79a 100644
--- a/input_sequence_test.cpp
+++ b/input_sequence_test.cpp
@@ -322,7 +322,7 @@ int test_main(int, char*[])
int const n = 9;
double const d[n] = {0, 1, 1, 3, 3, 5, 5, 7, 7};
std::string const e("0; 1 (0, 8]; 3 (2, 7]; 5 (4, 6]; 7");
- census += e + "\t\t! not a partition\t\n";
+ // census: invalid expression cannot be pasted into GUI
std::string const g("0 [0, 1); 1 [1, 9); 3 [3, 8); 5 [5, 7); 7 [7,
maturity)");
char const* m =
"Interval [ 9, 3 ) is improper: it ends before it begins."
@@ -445,7 +445,7 @@ int test_main(int, char*[])
strvec const c {"q", "q", "z", "p", "z", "z", "p", "z", "z", "z"};
double const d[n] = { 0 , 0 , 0 , 0 , 5 , 5 , 0 , 7 , 7 , 7 };
std::string const e("q [0, 2); p [3, 4); 5 [4, 6); p; 7");
- census += "sevenpay [0, 2); glp [3, 4); 5 [4, 6); glp; 7\t\t! not a
partition\t\n";
+ // census: invalid expression cannot be pasted into GUI
std::string const g(""); // Expression is invalid.
char const* m =
"Assertion 'a_default_keyword.empty() ||"
- [lmi-commits] [lmi] master updated (5753253 -> ce2981d), Greg Chicares, 2017/02/24
- [lmi-commits] [lmi] master a736dc8 2/7: Do not paste certain invalid unit tests to census,
Greg Chicares <=
- [lmi-commits] [lmi] master e220da9 1/7: Correct some unit-test expectations, Greg Chicares, 2017/02/24
- [lmi-commits] [lmi] master f2c8ba0 5/7: Remove a comment that is no longer relevant, Greg Chicares, 2017/02/24
- [lmi-commits] [lmi] master b04be04 3/7: Remove obsolete comments from census-pastable unit tests, Greg Chicares, 2017/02/24
- [lmi-commits] [lmi] master 6362631 4/7: Remove needless census-pastable unit tests, Greg Chicares, 2017/02/24
- [lmi-commits] [lmi] master ce2981d 7/7: Improve census-paste counterpart of a unit test, Greg Chicares, 2017/02/24
- [lmi-commits] [lmi] master cc9c75c 6/7: Show how census manager canonicalizes unit-test sequences, Greg Chicares, 2017/02/24