[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 3e089d5 03/10: Fix defect introduced 20110801
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 3e089d5 03/10: Fix defect introduced 20110801T2357Z: arguments omitted |
Date: |
Mon, 6 Feb 2017 04:10:56 +0000 (UTC) |
branch: master
commit 3e089d5c2604d661ffd6e9e83dc4e6adcf44d046
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Fix defect introduced 20110801T2357Z: arguments omitted
The two calls to the InputSequence ctor should both have supplied all
available parameters. The last two were omitted in the case where an
InputSequence is constructed for the sole purpose of obtaining its
parser diagnostics. This seems clearly to have been a mere oversight.
Apparently it would have caused incorrect behavior whenever the parser
would give nonempty diagnostics only with the omitted information.
---
input_sequence_entry.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/input_sequence_entry.cpp b/input_sequence_entry.cpp
index ffdbb1f..18a1000 100644
--- a/input_sequence_entry.cpp
+++ b/input_sequence_entry.cpp
@@ -1217,6 +1217,8 @@ wxString InputSequenceEditor::get_diagnostics_message()
,input_.inforce_year ()
,input_.effective_year ()
,keywords_
+ ,keywords_only_
+ ,default_keyword_
);
std::string parser_diagnostics(sequence.formatted_diagnostics());
rtrim(parser_diagnostics, "\n");
- [lmi-commits] [lmi] master updated (97d2acd -> 6eb2614), Greg Chicares, 2017/02/05
- [lmi-commits] [lmi] master 934e2f6 04/10: Emphasize that [lr]trim() removes no internal superfluity, Greg Chicares, 2017/02/05
- [lmi-commits] [lmi] master 3e089d5 03/10: Fix defect introduced 20110801T2357Z: arguments omitted,
Greg Chicares <=
- [lmi-commits] [lmi] master e52e02c 02/10: GUI sequence parser diagnostics: generalize code, improve documentation, Greg Chicares, 2017/02/05
- [lmi-commits] [lmi] master 987adcc 06/10: Get sequence parser diagnostics from exception, not function, Greg Chicares, 2017/02/05
- [lmi-commits] [lmi] master 6eb2614 10/10: Improve unit test, Greg Chicares, 2017/02/05
- [lmi-commits] [lmi] master 601f252 07/10: Throw any parser diagnostics from interval_representation(), Greg Chicares, 2017/02/05
- [lmi-commits] [lmi] master aee673f 05/10: Fix defect introduced 20170205T2107Z: fixed the wrong problem, Greg Chicares, 2017/02/05
- [lmi-commits] [lmi] master e411ac4 09/10: Throw any parser errors from all *_representation() functions, Greg Chicares, 2017/02/05
- [lmi-commits] [lmi] master 502fedc 01/10: Improve [lr]trim unit test and documentation, Greg Chicares, 2017/02/05
- [lmi-commits] [lmi] master 4f05707 08/10: Omit unhelpful file name and line number from a warning, Greg Chicares, 2017/02/05