lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 7031fc5 2/3: Revert "Revert "Allow empty comm


From: Greg Chicares
Subject: [lmi-commits] [lmi] master 7031fc5 2/3: Revert "Revert "Allow empty comments in rate tables""
Date: Sun, 11 Dec 2016 23:42:47 +0000 (UTC)

branch: master
commit 7031fc5a7f1e97d58383446446f73d0ffe14617c
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Revert "Revert "Allow empty comments in rate tables""
    
    This reverts commit eb8fbb6274b85a211cce518731b70b01b6fe6861.
    
    This temporary liberalization is needed for a little while longer so
    that a newly discovered category of flaws in historical rate tables
    can be investigated and fixed.
---
 rate_table.cpp |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/rate_table.cpp b/rate_table.cpp
index f2f7fb9..ddbf016 100644
--- a/rate_table.cpp
+++ b/rate_table.cpp
@@ -1299,7 +1299,9 @@ std::string* table_impl::parse_string
 {
     throw_if_duplicate_record(ostr.is_initialized(), field, line_num);
 
-    if(value.empty())
+    // With slight regret, allow the comments field to be empty because
+    // some historical files have put commentary in table name instead.
+    if(value.empty() && e_field_comments != field)
         {
         fatal_error()
             << "non-empty value must be specified for the field '"



reply via email to

[Prev in Thread] Current Thread [Next in Thread]