[lmi-commits] [6532] Enable more warnings in more situations

[Greg Chicares]

Revision: 6532
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=6532
Author:   chicares
Date:     2016-03-27 10:23:14 +0000 (Sun, 27 Mar 2016)
Log Message:
-----------
Enable more warnings in more situations

Modified Paths:
--------------
    lmi/trunk/ChangeLog
    lmi/trunk/configure.ac
    lmi/trunk/workhorse.make

Modified: lmi/trunk/ChangeLog
===================================================================
--- lmi/trunk/ChangeLog 2016-03-27 10:21:12 UTC (rev 6531)
+++ lmi/trunk/ChangeLog 2016-03-27 10:23:14 UTC (rev 6532)
@@ -38762,3 +38762,25 @@
   getopt.cpp
 Fix clang build: dangling 'else' (VZ).
 
+20160326T2340Z <address@hidden> [454]
+
+  census_document.cpp
+  gpt_document.cpp
+  illustration_document.cpp
+  mec_document.cpp
+  multidimgrid_any.cpp
+  multidimgrid_tools.hpp
+Remove unused parameters (VZ).
+
+20160327T1021Z <address@hidden> [454]
+
+  multidimgrid_any.cpp
+  tier_view_editor.cpp
+Avoid comparing signed and unsigned (VZ).
+
+20160327T1023Z <address@hidden> [454]
+
+  configure.ac
+  workhorse.make
+Enable more warnings in more situations.
+

Modified: lmi/trunk/configure.ac
===================================================================
--- lmi/trunk/configure.ac      2016-03-27 10:21:12 UTC (rev 6531)
+++ lmi/trunk/configure.ac      2016-03-27 10:23:14 UTC (rev 6532)
@@ -532,6 +532,7 @@
         -pedantic-errors \
         -Werror \
         -Wall \
+        -Wextra \
         -Wundef"
 
     if test "$CLANG" = "yes"; then

Modified: lmi/trunk/workhorse.make
===================================================================
--- lmi/trunk/workhorse.make    2016-03-27 10:21:12 UTC (rev 6531)
+++ lmi/trunk/workhorse.make    2016-03-27 10:23:14 UTC (rev 6532)
@@ -438,10 +438,12 @@
   -Wconversion \
   -Wdeprecated-declarations \
   -Wdisabled-optimization \
+  -Wextra \
   -Wimport \
   -Wmultichar \
   -Wpacked \
   -Wpointer-arith \
+  -Wredundant-decls \
   -Wsign-compare \
   -Wundef \
   -Wwrite-strings \
@@ -470,13 +472,10 @@
 #  -Wfloat-equal \
 
 # WX !! The wx library triggers many warnings with the following
-# 'extra' flags. (Use '-W' for backward compatibility, instead of the
-# modern equivalent '-Wextra'.)
+# 'extra' flags.
 
 gcc_common_extra_warnings := \
-  -W \
   -Wcast-qual \
-  -Wredundant-decls \
 
 ifeq (safestdlib,$(findstring safestdlib,$(build_type)))
   ifeq (3.4.5,$(gcc_version))
@@ -495,9 +494,12 @@
 #   http://lists.boost.org/Archives/boost/2006/03/102189.php
 # at least in version 1.33.1, and there seems to be no easy workaround
 # except to blow away all warning options and let a warning appear.
+# This problem seems not to occur with gcc-4.x .
 
-static_mutex.o: gcc_common_extra_warnings :=
-static_mutex.o:          gcc_cxx_warnings :=
+ifeq (3.4.5,$(gcc_version))
+  static_mutex.o: gcc_common_extra_warnings :=
+  static_mutex.o:          gcc_cxx_warnings :=
+endif
 
 # Boost normally makes '-Wundef' give spurious warnings:
 #   http://aspn.activestate.com/ASPN/Mail/Message/boost/1822550