[lmi-commits] [6390] Fix defect introduced 20050114T1947Z

[Greg Chicares]

Revision: 6390
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=6390
Author:   chicares
Date:     2015-11-06 22:05:23 +0000 (Fri, 06 Nov 2015)
Log Message:
-----------
Fix defect introduced 20050114T1947Z

Modified Paths:
--------------
    lmi/trunk/ChangeLog
    lmi/trunk/ihs_irc7702.cpp

Modified: lmi/trunk/ChangeLog
===================================================================
--- lmi/trunk/ChangeLog 2015-11-06 21:18:38 UTC (rev 6389)
+++ lmi/trunk/ChangeLog 2015-11-06 22:05:23 UTC (rev 6390)
@@ -37371,3 +37371,51 @@
   variable_annuity.xsl
 Fix spelling errors.
 
+20151102T2345Z <address@hidden> [472]
+
+  custom_io_1.cpp
+Stem cell proliferation in regression testing.
+
+20151102T2351Z <address@hidden> [472]
+
+  gpt_input.cpp
+  mec_input.cpp
+Propagate the 20150723T0941Z change to parallel code.
+
+20151104T0416Z <address@hidden> [472]
+
+  custom_io_1.cpp
+Reconcile generated input file before writing it.
+
+20151104T0510Z <address@hidden> [471]
+
+  accountvalue.cpp
+  custom_io_1.cpp
+  ihs_acctval.cpp
+  input.cpp
+  input.hpp
+Rename a function, explaining away what had seemed to be magic.
+
+20151104T1016Z <address@hidden> [471]
+
+  input_xml_io.cpp
+Improve documentation.
+
+20151106T1911Z <address@hidden> [471]
+
+  input_harmonization.cpp
+Assert certain invariants.
+
+20151106T2118Z <address@hidden> [471]
+
+  ledger.cpp
+Permit regression tests for withdrawn products.
+
+20151106T2205Z <address@hidden> [471]
+
+  ihs_irc7702.cpp
+Fix defect introduced 20050114T1947Z, from an original file predating
+the lmi epoch: cumulative GLP and cumulative 'premiums paid' weren't
+reinitialized where needed, causing their values to become enormous
+after multiple solve iterations.
+

Modified: lmi/trunk/ihs_irc7702.cpp
===================================================================
--- lmi/trunk/ihs_irc7702.cpp   2015-11-06 21:18:38 UTC (rev 6389)
+++ lmi/trunk/ihs_irc7702.cpp   2015-11-06 22:05:23 UTC (rev 6390)
@@ -714,12 +714,16 @@
 }
 
 /// For illustrations, we can't initialize everything in the ctor.
+///
 /// For instance, specamt might need to be calculated as a function
 /// of GLP or GSP, so it cannot always be known before the GPT
 /// calculations are available; and guideline premiums cannot be
 /// determined until specamt is set. Therefore, we need this function
 /// to initialize these things after specamt has been set. The server
 /// doesn't use it.
+///
+/// Furthermore, cumulative values must be reinitialized between solve
+/// iterations, and this function is the right place to do that.
 
 void Irc7702::Initialize7702
     (double            a_BftAmt
@@ -762,6 +766,9 @@
             ,LeastBftAmtEver
             );
         PriorGSP = PresentGSP;
+        CumGLP     = 0.0;
+        GptLimit   = std::max(CumGLP, PresentGSP);
+        CumPmts    = 0.0;
         }
     else
         {