[lmi-commits] [6343] Improve concinnity and microefficiency

[Greg Chicares]

Revision: 6343
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=6343
Author:   chicares
Date:     2015-10-10 17:11:46 +0000 (Sat, 10 Oct 2015)
Log Message:
-----------
Improve concinnity and microefficiency

Modified Paths:
--------------
    lmi/trunk/ihs_avdebug.cpp
    lmi/trunk/illustration_view.cpp
    lmi/trunk/illustrator.cpp
    lmi/trunk/wx_test_config_settings.cpp

Modified: lmi/trunk/ihs_avdebug.cpp
===================================================================
--- lmi/trunk/ihs_avdebug.cpp   2015-10-10 17:10:25 UTC (rev 6342)
+++ lmi/trunk/ihs_avdebug.cpp   2015-10-10 17:11:46 UTC (rev 6343)
@@ -265,7 +265,7 @@
 void AccountValue::SetDebugFilename(std::string const& s)
 {
     configurable_settings const& c = configurable_settings::instance();
-    std::string const z = c.spreadsheet_file_extension();
+    std::string const& z = c.spreadsheet_file_extension();
     DebugFilename = unique_filepath(s, ".monthly_trace" + z).string();
 }
 

Modified: lmi/trunk/illustration_view.cpp
===================================================================
--- lmi/trunk/illustration_view.cpp     2015-10-10 17:10:25 UTC (rev 6342)
+++ lmi/trunk/illustration_view.cpp     2015-10-10 17:11:46 UTC (rev 6343)
@@ -217,8 +217,8 @@
     LMI_ASSERT(ledger_values_.get());
     Timer timer;
     configurable_settings const& c = configurable_settings::instance();
-    std::string const b = base_filename();
-    std::string const e = c.spreadsheet_file_extension();
+    std::string const  b = base_filename();
+    std::string const& e = c.spreadsheet_file_extension();
     std::string spreadsheet_filename = unique_filepath(b, e).string();
     PrintCellTabDelimited(*ledger_values_, spreadsheet_filename);
     std::ifstream ifs(spreadsheet_filename.c_str());

Modified: lmi/trunk/illustrator.cpp
===================================================================
--- lmi/trunk/illustrator.cpp   2015-10-10 17:10:25 UTC (rev 6342)
+++ lmi/trunk/illustrator.cpp   2015-10-10 17:11:46 UTC (rev 6343)
@@ -198,7 +198,7 @@
     static Input       user_default;
 
     configurable_settings const& c = configurable_settings::instance();
-    std::string const default_input_file = c.default_input_filename();
+    std::string const& default_input_file = c.default_input_filename();
     if(0 != access(default_input_file.c_str(), F_OK))
         {
         user_default = builtin_default;

Modified: lmi/trunk/wx_test_config_settings.cpp
===================================================================
--- lmi/trunk/wx_test_config_settings.cpp       2015-10-10 17:10:25 UTC (rev 
6342)
+++ lmi/trunk/wx_test_config_settings.cpp       2015-10-10 17:11:46 UTC (rev 
6343)
@@ -91,8 +91,8 @@
     LMI_ASSERT_EQUAL(settings.libraries_to_preload(), "");
     LMI_ASSERT_EQUAL(settings.xsl_fo_command(), "CMD /c /fop-0.20.5/fop");
 
-    std::string skin = settings.skin_filename();
-    std::string default_input = settings.default_input_filename();
+    std::string const& skin = settings.skin_filename();
+    std::string const& default_input = settings.default_input_filename();
     LMI_ASSERT_WITH_MSG
         (  "skin_coli_boli.xrc"      == skin
         || "skin_group_carveout.xrc" == skin