[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [6248] Merge duplicative defect markers
From: |
Greg Chicares |
Subject: |
[lmi-commits] [6248] Merge duplicative defect markers |
Date: |
Thu, 13 Aug 2015 23:04:28 +0000 |
Revision: 6248
http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=6248
Author: chicares
Date: 2015-08-13 23:04:27 +0000 (Thu, 13 Aug 2015)
Log Message:
-----------
Merge duplicative defect markers
Modified Paths:
--------------
lmi/trunk/ledger_invariant.cpp
Modified: lmi/trunk/ledger_invariant.cpp
===================================================================
--- lmi/trunk/ledger_invariant.cpp 2015-08-13 22:20:34 UTC (rev 6247)
+++ lmi/trunk/ledger_invariant.cpp 2015-08-13 23:04:27 UTC (rev 6248)
@@ -35,15 +35,15 @@
#include "database.hpp"
#include "dbnames.hpp"
#include "death_benefits.hpp"
-#include "financial.hpp" // TODO ?? For IRRs--prolly don't blong here.
+#include "financial.hpp" // for CalculateIrrs()
#include "fund_data.hpp"
#include "input.hpp"
#include "interest_rates.hpp"
-#include "ledger.hpp" // TODO ?? For IRRs--prolly don't blong here.
-#include "ledger_variant.hpp" // TODO ?? For IRRs--prolly don't blong here.
+#include "ledger.hpp" // for CalculateIrrs()
+#include "ledger_variant.hpp" // for CalculateIrrs()
#include "loads.hpp"
-#include "mc_enum_aux.hpp" // mc_e_vector_to_string_vector()
-#include "mc_enum_types_aux.hpp" // mc_str()
+#include "mc_enum_aux.hpp" // mc_e_vector_to_string_vector()
+#include "mc_enum_types_aux.hpp" // mc_str()
#include "miscellany.hpp"
#include "outlay.hpp"
#include "premium_tax.hpp"
@@ -53,10 +53,6 @@
#include <ostream>
#include <stdexcept>
-// TODO ?? It is extraordinary that this 'invariant' class includes
-// some data that vary by basis. Perhaps they should be in the
-// complementary 'variant' class.
-
//============================================================================
LedgerInvariant::LedgerInvariant(int len)
:LedgerBase(len)
@@ -1102,7 +1098,10 @@
}
//============================================================================
-// TODO ?? Prolly don't blong here.
+// TODO ?? It is extraordinary that this "invariant" class uses and
+// even sets some data that vary by basis and therefore seem to belong
+// in the complementary "variant" class.
+
void LedgerInvariant::CalculateIrrs(Ledger const& LedgerValues)
{
int max_length = LedgerValues.GetMaxLength();
@@ -1150,10 +1149,8 @@
// matter not of efficiency but of validity: values for unused
// bases are not dependably initialized.
//
- // TODO ?? This calculation really needs to be distributed among
- // the variant ledgers, so that it gets run for every basis
- // actually used.
- //
+ // This calculation should be distributed among the variant
+ // ledgers, so that it gets run for every basis actually used.
if
(0 == std::count
(LedgerValues.GetRunBases().begin()
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [lmi-commits] [6248] Merge duplicative defect markers,
Greg Chicares <=