[lmi-commits] [5819] Enforce constness of an enum value argument

[Greg Chicares]

Revision: 5819
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=5819
Author:   chicares
Date:     2013-11-07 14:08:11 +0000 (Thu, 07 Nov 2013)
Log Message:
-----------
Enforce constness of an enum value argument

Modified Paths:
--------------
    lmi/trunk/ChangeLog
    lmi/trunk/group_values.cpp
    lmi/trunk/group_values.hpp

Modified: lmi/trunk/ChangeLog
===================================================================
--- lmi/trunk/ChangeLog 2013-11-04 18:29:11 UTC (rev 5818)
+++ lmi/trunk/ChangeLog 2013-11-07 14:08:11 UTC (rev 5819)
@@ -32809,3 +32809,42 @@
   group_values.cpp
 Experimentally pause between printouts.
 
+20131031T1243Z <address@hidden> [542]
+
+  group_values.cpp
+Improve documentation.
+
+20131031T1256Z <address@hidden> [542]
+
+  group_values.cpp
+Refactor.
+
+20131031T1343Z <address@hidden> [542]
+
+  group_values.cpp
+Add progress meters for potentially lengthy operations.
+
+20131104T1343Z <address@hidden> [542]
+
+  progress_meter_wx.cpp
+Alphabetize options.
+
+20131104T1823Z <address@hidden> [542]
+
+  progress_meter.hpp
+  progress_meter_test.cpp
+Test invariants in one place.
+
+20131104T1829Z <address@hidden> [542]
+
+  progress_meter_test.cpp
+Test shared-pointer reuse.
+
+20131107T1408Z <address@hidden> [542]
+
+  group_values.cpp
+  group_values.hpp
+Enforce constness of an enum value argument...in the implementation,
+though not in declarations. Although it's of a primitive type, it is
+important that its value not be changed.
+

Modified: lmi/trunk/group_values.cpp
===================================================================
--- lmi/trunk/group_values.cpp  2013-11-04 18:29:11 UTC (rev 5818)
+++ lmi/trunk/group_values.cpp  2013-11-07 14:08:11 UTC (rev 5819)
@@ -35,19 +35,19 @@
 #include "emit_ledger.hpp"
 #include "fenv_guard.hpp"
 #include "global_settings.hpp"
-#include "illustrator.hpp"       // assert_consistency()
+#include "illustrator.hpp"              // assert_consistency()
 #include "input.hpp"
 #include "ledger.hpp"
 #include "ledgervalues.hpp"
 #include "materially_equal.hpp"
-#include "mc_enum_types_aux.hpp" // mc_str()
+#include "mc_enum_types_aux.hpp"        // mc_str()
 #include "path_utility.hpp"
 #include "progress_meter.hpp"
 #include "timer.hpp"
 #include "value_cast.hpp"
 
-#include <algorithm>             // std::max()
-#include <iterator>              // std::back_inserter()
+#include <algorithm>                    // std::max()
+#include <iterator>                     // std::back_inserter()
 #include <string>
 
 namespace
@@ -112,10 +112,10 @@
 {
   public:
     census_run_result operator()
-        (fs::path const&           file
+        (fs::path           const& file
         ,mcenum_emission           emission
         ,std::vector<Input> const& cells
-        ,Ledger&                   composite
+        ,Ledger                  & composite
         );
 };
 
@@ -123,18 +123,18 @@
 {
   public:
     census_run_result operator()
-        (fs::path const&           file
+        (fs::path           const& file
         ,mcenum_emission           emission
         ,std::vector<Input> const& cells
-        ,Ledger&                   composite
+        ,Ledger                  & composite
         );
 };
 
 census_run_result run_census_in_series::operator()
-    (fs::path const&           file
-    ,mcenum_emission           emission
+    (fs::path           const& file
+    ,mcenum_emission    const  emission
     ,std::vector<Input> const& cells
-    ,Ledger&                   composite
+    ,Ledger                  & composite
     )
 {
     Timer timer;
@@ -256,10 +256,10 @@
 /// on an illustration.
 
 census_run_result run_census_in_parallel::operator()
-    (fs::path const&           file
-    ,mcenum_emission           emission
+    (fs::path           const& file
+    ,mcenum_emission    const  emission
     ,std::vector<Input> const& cells
-    ,Ledger&                   composite
+    ,Ledger                  & composite
     )
 {
     Timer timer;
@@ -697,8 +697,8 @@
 }
 
 census_run_result run_census::operator()
-    (fs::path const&           file
-    ,mcenum_emission           emission
+    (fs::path           const& file
+    ,mcenum_emission    const  emission
     ,std::vector<Input> const& cells
     )
 {

Modified: lmi/trunk/group_values.hpp
===================================================================
--- lmi/trunk/group_values.hpp  2013-11-04 18:29:11 UTC (rev 5818)
+++ lmi/trunk/group_values.hpp  2013-11-07 14:08:11 UTC (rev 5819)
@@ -26,7 +26,7 @@
 
 #include "config.hpp"
 
-#include "mc_enum_type_enums.hpp" // enum mcenum_emission
+#include "mc_enum_type_enums.hpp"       // enum mcenum_emission
 #include "obstruct_slicing.hpp"
 #include "so_attributes.hpp"
 
@@ -82,7 +82,7 @@
     ~run_census();
 
     census_run_result operator()
-        (fs::path const&           file
+        (fs::path           const& file
         ,mcenum_emission           emission
         ,std::vector<Input> const& cells
         );