[lmi-commits] [5251] Display busy cursor while preparing to edit input

[Greg Chicares]

Revision: 5251
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=5251
Author:   chicares
Date:     2011-08-15 00:22:34 +0000 (Mon, 15 Aug 2011)
Log Message:
-----------
Display busy cursor while preparing to edit input

Modified Paths:
--------------
    lmi/trunk/ChangeLog
    lmi/trunk/mvc_controller.cpp

Modified: lmi/trunk/ChangeLog
===================================================================
--- lmi/trunk/ChangeLog 2011-08-14 23:32:36 UTC (rev 5250)
+++ lmi/trunk/ChangeLog 2011-08-15 00:22:34 UTC (rev 5251)
@@ -28278,3 +28278,9 @@
 the lmi epoch: it's wasteful and confusing to test twice whether input
 changed.
 
+20110815T0022Z <address@hidden> [631]
+
+  mvc_controller.cpp
+Display busy cursor while preparing to edit input. See:
+  http://lists.nongnu.org/archive/html/lmi/2011-08/msg00047.html
+

Modified: lmi/trunk/mvc_controller.cpp
===================================================================
--- lmi/trunk/mvc_controller.cpp        2011-08-14 23:32:36 UTC (rev 5250)
+++ lmi/trunk/mvc_controller.cpp        2011-08-15 00:22:34 UTC (rev 5251)
@@ -43,18 +43,19 @@
 #include "wx_utility.hpp"
 #include "wx_workarounds.hpp"
 
-#include <wx/app.h> // wxApp::IsActive()
+#include <wx/app.h>                     // wxApp::IsActive()
 #include <wx/checkbox.h>
 #include <wx/ctrlsub.h>
 #include <wx/datectrl.h>
 #include <wx/radiobox.h>
 #include <wx/spinctrl.h>
 #include <wx/textctrl.h>
+#include <wx/utils.h>                   // wxBusyCursor
 #include <wx/xrc/xmlres.h>
 #include <wx/wupdlock.h>
 
-#include <cstddef>  // std::size_t
-#include <cstring>  // std::strlen()
+#include <cstddef>                      // std::size_t
+#include <cstring>                      // std::strlen()
 
 namespace
 {
@@ -96,6 +97,15 @@
 {
     model_.TestInitialConsistency();
 
+    // Show busy cursor only after TestInitialConsistency() returns,
+    // because that function may pop up a messagebox in reasonable
+    // circumstances: if that happens, it's too confusing to leave
+    // the busy cursor alone, and too complicated to remove it; and
+    // that function is normally quite fast. Messageboxes are not
+    // expected to appear in the rest of this ctor unless something
+    // is gravely wrong.
+    wxBusyCursor wait;
+
     char const* resource_file_name = view_.ResourceFileName();
     LMI_ASSERT(0 != resource_file_name && 0 != 
std::strlen(resource_file_name));