[lmi-commits] [5244] Remove several defect markers that are now recognized as jejune

[Greg Chicares]

Revision: 5244
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=5244
Author:   chicares
Date:     2011-08-11 22:16:41 +0000 (Thu, 11 Aug 2011)
Log Message:
-----------
Remove several defect markers that are now recognized as jejune

Modified Paths:
--------------
    lmi/trunk/ChangeLog
    lmi/trunk/census_view.cpp

Modified: lmi/trunk/ChangeLog
===================================================================
--- lmi/trunk/ChangeLog 2011-08-11 22:08:37 UTC (rev 5243)
+++ lmi/trunk/ChangeLog 2011-08-11 22:16:41 UTC (rev 5244)
@@ -28212,3 +28212,20 @@
 Disable deletion if no cell is selected. See:
   http://lists.nongnu.org/archive/html/lmi/2011-08/msg00044.html
 
+20110811T2203Z <address@hidden> [637]
+
+  census_view.cpp
+Enable "class" items consistently. This change affects only a command
+that is not presently offered, so it has no user-observable effect.
+
+20110811T2208Z <address@hidden> [637]
+
+  census_view.cpp
+  census_view.hpp
+Rename enablement functions for clarity.
+
+20110811T2216Z <address@hidden> [632]
+
+  census_view.cpp
+Remove several defect markers that are now recognized as jejune.
+

Modified: lmi/trunk/census_view.cpp
===================================================================
--- lmi/trunk/census_view.cpp   2011-08-11 22:08:37 UTC (rev 5243)
+++ lmi/trunk/census_view.cpp   2011-08-11 22:16:41 UTC (rev 5244)
@@ -157,7 +157,6 @@
     EVT_MENU(XRCID("column_width_varying"  
),CensusView::UponColumnWidthVarying)
     EVT_MENU(XRCID("column_width_fixed"    ),CensusView::UponColumnWidthFixed)
 
-// TODO ?? There has to be a better way than this.
     EVT_UPDATE_UI(XRCID("edit_cell"            
),CensusView::UponUpdateSingleSelection)
     EVT_UPDATE_UI(XRCID("edit_class"           
),CensusView::UponUpdateSingleSelection)
     EVT_UPDATE_UI(XRCID("edit_case"            
),CensusView::UponUpdateAlwaysEnabled)
@@ -220,7 +219,6 @@
     return document().doc_.class_parms_;
 }
 
-// TODO ?? Is this abstraction actually useful?
 std::string CensusView::cell_title(int index)
 {
     std::string full_name(cell_parms()[index]["InsuredName"].str());
@@ -233,7 +231,6 @@
     return title.str();
 }
 
-// TODO ?? Is this abstraction actually useful?
 std::string CensusView::class_title(int index)
 {
     std::string class_name = class_name_from_cell_number(index);
@@ -251,7 +248,6 @@
     return title.str();
 }
 
-// TODO ?? Is this abstraction actually useful?
 std::string CensusView::class_name_from_cell_number(int cell_number) const
 {
     return cell_parms()[cell_number]["EmployeeClass"].str();
@@ -438,7 +434,6 @@
             // insert its parameters into the rebuilt vector.
             std::vector<Input>::const_iterator j = cell_parms().begin();
             bool found = false;
-            // TODO ?? There has to be a nicer way to do this with STL.
             while(j != cell_parms().end())
                 {
                 if(*n == (*j)["EmployeeClass"].str())