[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Linphone-users] linphone segfault when released without prior termi
From: |
Gautier Pelloux-Prayer |
Subject: |
Re: [Linphone-users] linphone segfault when released without prior terminate |
Date: |
Fri, 15 Jan 2016 15:40:59 +0100 |
Hi Christian,
Thanks for the patch! However I cannot apply yet for two reasons:
- firstly, and the most important point, we would need a scenario where this
use case happens to understand why Linphone is behavying like that; if you can
provide us logs (you can sent it to me directly if it should not be public) it
would ease the patch integration
- secondly, due to licence issue, we would need you to sign the contributor
agreement (see
http://www.belledonne-communications.com/downloads/Belledonne_communications_CA.pdf).
Have a nice weekend,
Gautier Pelloux-Prayer
Software Engineer @ Belledonne Communications
> On 14 Jan 2016, at 12:39, Christian Spielberger <address@hidden> wrote:
>
> On Thu 14.01.16 08:35, Christian Spielberger wrote:
>> Hi,
>>
>> in some situations (e.g. io errors, SIP errors) call_released is called
>> without
>> prior call_terminated. These leads to a segfault, later when
>> linphone_core_iterate
>> is called, because the call object is freed but not removed from the calls
>> list.
>>
>> In my case (some kind of SIP error, which should not be discussed here) in
>> sal_op_call.c function process_dialog_terminated calls call_set_released
>> without
>> prior p->base.root->callbacks.call_terminated, because it does not run into
>> the
>> BELLE_SIP_DIALOG_CONFIRMED case. Instead we have BELLE_SIP_DIALOG_EARLY. The
>> call
>> state changes from LinphoneCallOutgoingEarlyMedia directly to
>> LinphoneCallReleased.
>>
>> There might be also some cases of call_set_released without prior
>> termination in
>> function call_process_response. Maybe they also lead to a segfault.
>>
>> I have linphone 3.9.1 with belle-sip 1.4.2.
>>
>> Regards,
>> Christian Spielberger.
>>
>>
>> _______________________________________________
>> Linphone-users mailing list
>> address@hidden
>> https://lists.nongnu.org/mailman/listinfo/linphone-users
>
> I saw that there something changed since tag 3.9.1, but there is still a
> segfault.
>
> I would suggest the attached patch.
>
> --
> Best regards
>
> Christian Spielberger
> <0001-bellesip_sal-fix-segfault-in-case-of-early-dialog-te.patch>_______________________________________________
> Linphone-users mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/linphone-users