Re: [Linphone-users] [PATCH] belle-spi crash with malformed linphone log entries

[Gautier Pelloux-Prayer]

Gautier Pelloux-Prayer
Software Engineer @ Belledonne Communications

> On 23 Nov 2015, at 11:15, François Guerraz <address@hidden> wrote:
> 
> Hi Gautier,
> 
> For some reasons, one of my calls failed miserably, I can’t remember what the 
> error was, but it lead to NULL entries being saved in my call log (for the 
> phone number field for example).
> 
Yes, that's the root issue which should not happen. We need to know why this is 
happening.

> If you can’t reproduce it, I can send you my log or a log I can reproduce it 
> with.
> 
Yes, please do.
> As to where the fix should be, it’s your software but I’m sure there’s two 
> school of thoughts, I personally think that low level functions should check 
> their input…
> 
Indeed, there are 2 schools here ;-).

> Best regards,
> François
> 
>> On 23 Nov 2015, at 08:54, Gautier Pelloux-Prayer <address@hidden> wrote:
>> 
>> Hi François,
>> 
>> Thanks for your patch! Can you describe us what reproductible scenario lead 
>> belle-sip to crash? 
>> Actually, the fix should not be in belle-sip but probably more in 
>> liblinphone which is doing something wrong. We have to guess what! :).
>> 
>> Cheers,
>> 
>> Gautier Pelloux-Prayer
>> Software Engineer @ Belledonne Communications
>> 
>>> On 21 Nov 2015, at 15:54, François Guerraz <address@hidden> wrote:
>>> 
>>> <fix-multiple-crashes-with-malformed-log-entries.patch>
>> 
>> 
>> _______________________________________________
>> Linphone-users mailing list
>> address@hidden
>> https://lists.nongnu.org/mailman/listinfo/linphone-users
> 
> 
> _______________________________________________
> Linphone-users mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/linphone-users