[Linphone-users] Video patch for 0.12.1

[Matt Lawson]

Hello everyone,

We are using Linphone pretty successfully with video.  The version I 
have is somewhat removed from the Linphone CVS.  However, I plan to try 
to contribute as many fixes as I can identify.

In the file coreapi/osipuacb.c there are two instances where 
audio_rtp_port is listed instead of video_rtp_port.  Clearly a cut and 
paste error.  This patch corrects that.  The patch is relative to 
0.12.1.  I have pasted it below as well as included it as an attachment 
so you can use whichever is easier.

- Matt




--- osipuacb.c.0.12.1   2003-12-02 15:20:56.000000000 -0500
+++ osipuacb.c.modified 2003-12-02 15:25:04.000000000 -0500
@@ -437,7 +437,7 @@
       params=&diaparams->video_params;
       if (params->initialized==0){
               /* this is the first codec we may accept*/
-               
params->localport=payload->localport=lc->rtp_conf.audio_rtp_port;
+               
params->localport=payload->localport=lc->rtp_conf.video_rtp_port;
               params->remoteport=payload->remoteport;
               params->line=payload->line;
               params->pt=payload->pt; /* remember the first payload 
accepted */
@@ -465,7 +465,7 @@
       /* paranoid check: see if this codec is supported in our local 
rtp profile*/
       
supported=payload_is_supported(payload,lc->local_profile,diaparams->profile);
       if (!supported) {
-               g_warning("this fucking remote sip phone did not 
answered properly to my sdp offer!");
+               g_warning("This remote sip phone did not answer properly 
to my sdp offer!");
               return 0;
       }
       params=&diaparams->audio_params;
@@ -495,13 +495,13 @@
       /* paranoid check: see if this codec is supported in our local 
rtp profile*/
       
supported=payload_is_supported(payload,lc->local_profile,diaparams->profile);
       if (!supported) {
-               g_warning("this fucking remote sip phone did not 
answered properly to my sdp offer!");
+               g_warning("This remote sip phone did not answer properly 
to my sdp offer!");
               return 0;
       }
       params=&diaparams->video_params;
       if (params->initialized==0){
               /* this is the first codec we may accept*/
-               params->localport=lc->rtp_conf.audio_rtp_port;
+               params->localport=lc->rtp_conf.video_rtp_port;
               params->remoteport=payload->remoteport;
               params->line=payload->line;
               params->pt=payload->pt; /* remember the first payload 
accepted */

--- osipuacb.c.0.12.1   2003-12-02 15:20:56.000000000 -0500
+++ osipuacb.c.modified 2003-12-02 15:25:04.000000000 -0500
@@ -437,7 +437,7 @@
        params=&diaparams->video_params;
        if (params->initialized==0){
                /* this is the first codec we may accept*/
-               
params->localport=payload->localport=lc->rtp_conf.audio_rtp_port;
+               
params->localport=payload->localport=lc->rtp_conf.video_rtp_port;
                params->remoteport=payload->remoteport;
                params->line=payload->line;
                params->pt=payload->pt; /* remember the first payload accepted 
*/
@@ -465,7 +465,7 @@
        /* paranoid check: see if this codec is supported in our local rtp 
profile*/
        
supported=payload_is_supported(payload,lc->local_profile,diaparams->profile);
        if (!supported) {
-               g_warning("this fucking remote sip phone did not answered 
properly to my sdp offer!");
+               g_warning("This remote sip phone did not answer properly to my 
sdp offer!");
                return 0;
        }
        params=&diaparams->audio_params;
@@ -495,13 +495,13 @@
        /* paranoid check: see if this codec is supported in our local rtp 
profile*/
        
supported=payload_is_supported(payload,lc->local_profile,diaparams->profile);
        if (!supported) {
-               g_warning("this fucking remote sip phone did not answered 
properly to my sdp offer!");
+               g_warning("This remote sip phone did not answer properly to my 
sdp offer!");
                return 0;
        }
        params=&diaparams->video_params;
        if (params->initialized==0){
                /* this is the first codec we may accept*/
-               params->localport=lc->rtp_conf.audio_rtp_port;
+               params->localport=lc->rtp_conf.video_rtp_port;
                params->remoteport=payload->remoteport;
                params->line=payload->line;
                params->pt=payload->pt; /* remember the first payload accepted 
*/